[RF] Use RooDataHist interfaces with index input arguments#21977
Open
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Open
[RF] Use RooDataHist interfaces with index input arguments#21977guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
Use RooDataHist interfaces that take index input arguments, which is safer because they don't rely on the cached last index in the RooDataHist. Addresses one bullet point in root-project#6557: "Correct interface of RooAbsData and derived classes to use e.g. std::size_t for indexing events. int doesn't make sense." As a followup, we could consider to deprecate the interfaces that use the last cached "current" index.
Test Results 22 files 22 suites 3d 11h 12m 22s ⏱️ Results for commit 51edfcb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use RooDataHist interfaces that take index input arguments, which is safer because they don't rely on the cached last index in the RooDataHist.
Addresses one bullet point in
#6557:
"Correct interface of RooAbsData and derived classes to use e.g. std::size_t for indexing events. int doesn't make sense."
As a followup, we could consider to deprecate the interfaces that use the last cached "current" index.