Skip to content

[tmva][sofie] Remove (float*) cast in emitted code by GEMM operator #21980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Apr 21, 2026
+2 −5
Merged

[tmva][sofie] Remove (float*) cast in emitted code by GEMM operator #21980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tmva/sofie/inc/TMVA/ROperator_Gemm.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,12 +423,9 @@ namespace SOFIE{
<< (fAttrTransB ? "true, " : "false, ")
<< (fAttrTransA ? "true, " : "false, ")
<< n << ", " << m << ", " << k << ", ";
// TODO: the cast to (float *) is not needed here from the C++ language perspective (the arguments to
// Gemm_Call are const already), but Clad bug https://github.com/vgvassilev/clad/issues/1721 is requiring
// us to do this cast to keep Clad working. Remove this hack once the Clad issue is fixed.
out << std::setprecision(std::numeric_limits<float>::max_digits10) << fAttrAlpha << ", (float*)tensor_" << fNB;
out << std::setprecision(std::numeric_limits<float>::max_digits10) << fAttrAlpha << ", tensor_" << fNB;
if (extraB) out << " + " << opName << "_B_offset";
out << ", (float*)tensor_" << fNA; // TODO: same here
out << ", tensor_" << fNA;
if (extraA) out << " + " << opName << "_A_offset";
out << ", " << std::setprecision(std::numeric_limits<float>::max_digits10) << fAttrBeta << ",";
// in the case of bias and no broadcasting needed - I need to add bias as an extra tensor in Gemm call
Expand Down
Loading