Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tree/dataframe/src/RDFSnapshotHelpers.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@
if (!outFile || outFile->IsZombie())
throw std::invalid_argument("Snapshot: cannot open file \"" + fileName + "\" in update mode");

auto *outNTuple = outFile->Get<ROOT::RNTuple>(ntupleName.c_str());
std::unique_ptr<RNTuple> uoNT { outFile->Get<ROOT::RNTuple>(ntupleName.c_str()) };

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / debian13 dev=ON, CMAKE_CXX_FLAGS=-Wsuggest-override

invalid conversion from ‘ROOT::RNTuple*’ to ‘int’ [-fpermissive]

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / debian13 dev=ON, CMAKE_CXX_FLAGS=-Wsuggest-override

template argument 2 is invalid

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / debian13 dev=ON, CMAKE_CXX_FLAGS=-Wsuggest-override

template argument 1 is invalid

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / debian13 dev=ON, CMAKE_CXX_FLAGS=-Wsuggest-override

‘RNTuple’ was not declared in this scope; did you mean ‘ROOT::RNTuple’?

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / opensuse15 march_native

invalid conversion from ‘ROOT::RNTuple*’ to ‘int’ [-fpermissive]

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / opensuse15 march_native

template argument 2 is invalid

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / opensuse15 march_native

template argument 1 is invalid

Check failure on line 263 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / opensuse15 march_native

‘RNTuple’ was not declared in this scope; did you mean ‘ROOT::RNTuple’?
Comment thread
ferdymercury marked this conversation as resolved.
Outdated
auto *outNTuple = uoNT.get();

Check failure on line 264 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / debian13 dev=ON, CMAKE_CXX_FLAGS=-Wsuggest-override

request for member ‘get’ in ‘uoNT’, which is of non-class type ‘int’

Check failure on line 264 in tree/dataframe/src/RDFSnapshotHelpers.cxx

View workflow job for this annotation

GitHub Actions / opensuse15 march_native

request for member ‘get’ in ‘uoNT’, which is of non-class type ‘int’

if (outNTuple) {
if (opts.fOverwriteIfExists) {
Expand Down Expand Up @@ -937,6 +938,8 @@
writeOptions.SetEnablePageChecksums(fOptions.fEnablePageChecksums);
writeOptions.SetEnableSamePageMerging(fOptions.fEnableSamePageMerging);

// Delete beforehand (.reset does it in inverse order, creates new and then deletes)
delete fOutputFile.release();
fOutputFile.reset(TFile::Open(fFileName.c_str(), fOptions.fMode.c_str()));
if (!fOutputFile)
throw std::runtime_error("Snapshot: could not create output file " + fFileName);
Expand Down
Loading