[6.38] Allow retrieving dataset top-level field names#22011
Closed
root-project-bot wants to merge 2 commits intoroot-project:v6-38-00-patchesfrom
Closed
[6.38] Allow retrieving dataset top-level field names#22011root-project-bot wants to merge 2 commits intoroot-project:v6-38-00-patchesfrom
root-project-bot wants to merge 2 commits intoroot-project:v6-38-00-patchesfrom
Conversation
Useful for instance when calling Snapshot and wanting to select only top-level field names, possibly further filtering the list (e.g. through regexes). (cherry picked from commit 1f3af5a)
Enabling the GetTopLevelFieldNames method in RNTuple exposed one previously faulty interaction between this and Snapshot. For the case of Snapshot with a regex, the regex would only consider top-level column names. If the regex contains a specific name of a subfield, e.g. "columnName.dataMember", then the regex would fail even though that column exists in the dataset. This commit also keeps the default Snapshot behaviour of only considering the top-level column names, but checks for the full list of column names in case a regex failed before throwing the final error if necessary. (cherry picked from commit 13bb547)
root-project-bot
requested review from
martamaja10 and
vepadulano
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21956, requested by @dpiparo. For your information @vepadulano