Skip to content

Fix zbar includes for colcon builds #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfinean wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

Fix zbar includes for colcon builds #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e33dc3
Fix zbar includes for colcon builds
mfinean Nov 24, 2025
287dd12
Skip copyright check
mfinean Nov 24, 2025
8269e7f
Include at the top
mfinean Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions zbar_ros/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,38 @@ find_package(sensor_msgs REQUIRED)
find_package(zbar_ros_interfaces REQUIRED)
find_package(cv_bridge REQUIRED)

# Include header files
include_directories(
include)
# Find zbar library
find_library(ZBAR_LIBRARY
NAMES zbar
)

find_path(ZBAR_INCLUDE_DIR
NAMES zbar.h
)

if(NOT ZBAR_LIBRARY)
message(FATAL_ERROR "zbar library not found. Please install libzbar-dev")
endif()

if(NOT ZBAR_INCLUDE_DIR)
message(FATAL_ERROR "zbar.h not found. Please install libzbar-dev")
endif()


# Build library
add_library(barcode_reader_node src/barcode_reader_node.cpp)
target_include_directories(barcode_reader_node PUBLIC
${ZBAR_INCLUDE_DIR}
include
)
target_link_libraries(barcode_reader_node PUBLIC
${sensor_msgs_TARGETS}
${std_msgs_TARGETS}
${zbar_ros_interfaces_TARGETS}
cv_bridge::cv_bridge
rclcpp::rclcpp
sensor_msgs::sensor_msgs_library
zbar
${ZBAR_LIBRARY}
)

# Build executable
Expand Down
4 changes: 3 additions & 1 deletion zbar_ros/include/zbar_ros/barcode_reader_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,13 @@
#ifndef ZBAR_ROS__BARCODE_READER_NODE_HPP_
#define ZBAR_ROS__BARCODE_READER_NODE_HPP_

#include <zbar.h>

#include <string>
#include <unordered_map>

#include "rclcpp/rclcpp.hpp"
#include "rclcpp/timer.hpp"
#include "./zbar.h"
#include "sensor_msgs/msg/image.hpp"
#include "std_msgs/msg/string.hpp"
#include "zbar_ros_interfaces/msg/symbol.hpp"
Expand Down
4 changes: 4 additions & 0 deletions zbar_ros_interfaces/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ ament_export_dependencies(rosidl_default_runtime)

if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)

# Skip copyright check, because the copyright used is not recognised by ament_copyright
set(ament_cmake_copyright_FOUND TRUE)

ament_lint_auto_find_test_dependencies()
endif()

Expand Down