Create my very own markdown file 😃 #340
Conversation
Signed-off-by: ericsandu <eric_andrei.sandu@stud.acs.upb.ro>
Signed-off-by: ericsandu <eric_andrei.sandu@stud.acs.upb.ro>
There was a problem hiding this comment.
Pull request overview
Adds new Markdown content to the workshop repository, including a personal “my favorite food” page and a multi-language Hello World reference page.
Changes:
- Added
myownmarkdown.mdwith headings, lists, tables, images, and an embedded Go code sample. - Added
helloworld.mdwith a language/tooling summary table and Hello World snippets plus build/run instructions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| myownmarkdown.md | Personal markdown showcase (image, lists, table, and embedded Go snippet). |
| helloworld.md | Hello World examples across languages with a summary table and run/build steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Run with: | ||
|
|
||
| ```console | ||
| ./helloworld |
There was a problem hiding this comment.
PHP section run instructions are incorrect: ./helloworld won’t run a PHP script directly unless it’s executable with a shebang and correct filename. Use php helloworld.php (or make the script executable and document that).
| ./helloworld | |
| php helloworld.php |
| # My favorite food | ||
|
|
||
| ## Can you guess it? |
There was a problem hiding this comment.
PR description mentions adding myownmarkdown.md, but this PR also introduces helloworld.md. Please update the PR description to reflect both files (or explain why helloworld.md is included).
| Here is some cool Go code to do just that: [Original repository](https://github.com/harrybrwn/apizza) | ||
|
|
||
| ```go | ||
| package cmd | ||
|
|
There was a problem hiding this comment.
This embeds a large block of third-party code from an external repository. To avoid licensing/attribution issues, consider replacing it with a small excerpt, or add explicit license/attribution text consistent with that project’s license (a link alone may not be sufficient).
|  | ||
|
|
||
| We list below Helloworld programs for different programming languages, i.e. programs that print "Hello, World!". | ||
| The specified compiler or interpreter is required for each programming languages. |
There was a problem hiding this comment.
Grammar: “for each programming languages” should be “for each programming language”.
| The specified compiler or interpreter is required for each programming languages. | |
| The specified compiler or interpreter is required for each programming language. |
| Build with: | ||
|
|
||
| ```console | ||
| gdc -Wall -o helloworld helloworld.cpp |
There was a problem hiding this comment.
The D example’s build command compiles helloworld.cpp, but the snippet is D code. This should reference the D source file (e.g., helloworld.d) to avoid confusing/inaccurate instructions.
| gdc -Wall -o helloworld helloworld.cpp | |
| gdc -Wall -o helloworld helloworld.d |
| ## Perl | ||
|
|
||
| ```pl | ||
| print("Hello, World!\n") |
There was a problem hiding this comment.
Perl snippet is missing a trailing semicolon, which makes it invalid Perl. Add the semicolon so the example runs as written.
| print("Hello, World!\n") | |
| print("Hello, World!\n"); |
| Build with: | ||
|
|
||
| ```console | ||
| rustc hello.rs | ||
| ``` | ||
|
|
||
| Run with: | ||
|
|
||
| ```console | ||
| ./helloworld | ||
| ``` |
There was a problem hiding this comment.
Rust section: rustc hello.rs will produce a hello binary by default, but the instructions say to run ./helloworld. Either specify -o helloworld (or rename the output) or update the run command to match the produced binary.
Fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adds a personally written markdown file containing all of the main structures as described in the workshop.
myownmarkdown.mdcontains a silly write up about my favorite food and showcases a very cool project related to it.