Conversation
…strip Two coupled durable fixes pinned together for iq10-rrd flashing: 1. partitions.conf: drop --filename=tools.fv from the toolsfv partition. No recipe produces a tools.fv binary and none exists in the qcomflash deploy tree; the reference-board template left the filename behind, so gen_partition emitted a rawprogram entry for a non-existent file and the flasher failed with 'Failed to Open File ... tools.fv: Invalid argument'. toolsfv keeps its GPT slot (filename=""), matching its siblings quantumcontentfv/quantumfv/quantumsdk. 2. loaders/conf.read_conf: strip inline comments before tokenising (ported from PR #14 959845e). The 5ee8fff line this fix was based on predated that loader fix; re-pinning without it would silently reopen the inline-comment trap (a '# ... --filename=foo' comment leaking a dropped filename token back into getopt). 107 unit tests pass.
…ruth Rebuild platforms/iq10-rrd/ufs/partitions.conf from the authoritative meta_8_25 GPT + rawprogram layout (188 spec entries + synthesized per-LUN last_parti sentinels, 193 --partition lines across LUN 0-6). Validated with gen_partition (rc=0, 7 physical_partitions, well-formed XML, correct size-0 sentinel tails) and a field-by-field diff against the spec ground truth (0 mismatches). No --attributes/--readonly are emitted. check-missing-files reports 22 new-board boot binaries not yet on its allowlist (adsp*/cdsp*/soccp.mbn/gearvm.mbn/ddr_lcp.elf/oem_misc.mbn/ qti_misc.mbn/xbl_ramdump.elf/license.bin/Quantum.fv/quantumsdk.fv), all transcribed verbatim from the spec. Per repo convention these are added in a separate "tests: check-missing-files: add file(s) used by iq10-rrd" commit, not bundled into this layout change. Signed-off-by: Roshan Sivakumar <roshs@qti.qualcomm.com>
The meta_8_25 regen re-introduced the LUN0 vendor_a partition, but there
is no vendor_b sibling in the spec. qcom-ptool's ValidatePartitions() does
a lexical endswith("_a")/endswith("_b") A/B pairing check and fatally
aborts ptool -x when _a is present without _b, breaking the in-build
qcom-partition-conf do_compile (Makefile %/gpt target). vendor_a is a
contentless reserved single slot (filename=""), not half of an A/B pair,
so dropping it is safe and restores ptool -x rc=0.
Per-LUN partition counts now [7,16,16,16,81,55,1].
roshs189
added a commit
to roshs189/meta-qcom
that referenced
this pull request
Sep 9, 2026
Adds conf/machine/iq10-rrd.conf, ci/iq10-rrd.yml, and supporting BSP recipes for iq10-rrd, and points qcom-ptool.inc at the head of roshs189/qcom-ptool#15 (fix/iq10-rrd-drop-toolsfv-filename on qcom-ptool) so the build picks up its partition files. Signed-off-by: Roshan Sivakumar <roshs@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates
platforms/iq10-rrd/ufs/partitions.conffrom the authoritative meta_8_25 GPT + rawprogram layout (188 spec entries + synthesized per-LUNlast_partisentinels = 193--partitionlines, LUN 0-6).Validated via
gen_partition(rc=0, 7 physical_partitions, well-formed XML, correct size-0 sentinel tails) and a field-by-field diff vs the spec ground truth (0 mismatches). No--attributes/--readonlyemitted.Follow-up (separate commit, not in this PR):
check-missing-filesflags 22 new-board boot binaries not yet on its allowlist (adsp*/cdsp*/soccp.mbn/gearvm.mbn/ddr_lcp.elf/oem_misc.mbn/qti_misc.mbn/xbl_ramdump.elf/license.bin/Quantum.fv/quantumsdk.fv) — all transcribed verbatim from the spec. Per repo convention these belong in atests: check-missing-files: add file(s) used by iq10-rrdcommit.Note: ptool's local
ValidatePartitions()A/B-pairing check flagsvendor_a(a contentless reserved single slot with no image) via a purely lexicalendswith("_a")test. Layout validated through the gen_partition path; the validator limitation is reported separately to the ptool owner.