[build] Switch tsconfig base moduleResolution to bundler#1789
Open
Juice10 wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 1ec1c8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
changed the title
Contributor
|
Size Change: 0 B Total Size: 10.1 MB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript module resolution strategy from "Node" to "bundler" in the base TypeScript configuration, aligning TypeScript's import resolution with the project's bundler-based build tooling (Vite/Rollup). The change affects all packages in the monorepo that extend tsconfig.base.json.
Changes:
- Changed moduleResolution from "Node" to "bundler" in tsconfig.base.json
- Added an empty changeset for this internal configuration update
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.base.json | Updated moduleResolution to "bundler" to align TypeScript resolution with Vite/Rollup |
| .changeset/cool-cars-smile.md | Empty changeset following project convention for internal-only config changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch moduleResolution in tsconfig.base.json from Node to bundler
Why
rrweb is built as ESM with bundler-first tooling (Vite/Rollup). Using moduleResolution=bundler makes TypeScript resolve imports the same way our bundler does, including modern package exports/imports behavior.
This alignment helps catch invalid deep imports earlier and reduces TS-vs-bundler mismatches where code type-checks but fails during bundling or runtime.