Skip to content

fix(replay): fix playback stopping when skipping backwards with virtual DOM #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d0ugal wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −3
Open

fix(replay): fix playback stopping when skipping backwards with virtual DOM #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a99ce0
fix(replay): fix playback stopping when skipping backwards with virtu…
d0ugal Mar 18, 2026
69158a5
Apply formatting changes
d0ugal Mar 18, 2026
d42e107
Merge branch 'master' into fix/virtual-dom-backward-skip
d0ugal Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-virtual-dom-backward-skip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"rrweb": patch
---

Fix playback stopping when skipping backwards with useVirtualDom enabled
7 changes: 4 additions & 3 deletions packages/rrweb/src/replay/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,8 @@ export class Replayer {
console.warn(e);
}

this.virtualDom.destroyTree();
this.usingVirtualDom = false;

// If these legacy missing nodes haven't been resolved, they should be converted to real Nodes.
// This must happen before destroyTree() which resets the virtual DOM mirror.
if (Object.keys(this.legacy_missingNodeRetryMap).length) {
for (const key in this.legacy_missingNodeRetryMap) {
try {
Expand All @@ -292,6 +290,9 @@ export class Replayer {
}
}

this.virtualDom.destroyTree();
this.usingVirtualDom = false;

this.constructedStyleMutations.forEach((data) => {
this.applyStyleSheetMutation(data);
});
Expand Down