fix(utils): use Zone.js unpatched MutationObserver on Safari#1826
Open
d0ugal wants to merge 2 commits into
Open
fix(utils): use Zone.js unpatched MutationObserver on Safari#1826d0ugal wants to merge 2 commits into
d0ugal wants to merge 2 commits into
Conversation
Angular's Zone.js monkey-patches MutationObserver, causing rrweb's getUntaintedPrototype to fall back to creating an iframe and using its contentWindow.MutationObserver. On Safari/WebKit, a MutationObserver from an iframe's contentWindow silently never fires callbacks when observing the parent document — resulting in zero DOM mutations captured. Zone.js stores the original unpatched globals under a symbol key (Zone.__symbol__). Use this to retrieve the native MutationObserver before attempting the iframe fallback. Ref: PostHog/posthog-js#1687
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Angular's Zone.js is present, it monkey-patches
MutationObserver. rrweb'sgetUntaintedPrototypedetects the patched version and falls back to creating a hidden iframe, then usesiframe.contentWindow.MutationObserverto get an unpatched observer.On Safari/WebKit, a
MutationObserverobtained from an iframe'scontentWindowsilently never fires callbacks when observing nodes in the parent document. This means rrweb captures zero DOM mutations — full snapshots work, but all incremental changes are lost.Fix
Zone.js stores original unpatched globals under
globalThis[Zone.__symbol__(key)]. Before attempting the iframe fallback, check if Zone.js has stored the nativeMutationObserverand use it directly.This is the same approach used by PostHog: PostHog/posthog-js#1687
Testing
Verified with Angular apps (Zone.js present) across Chrome, Firefox, and Safari (Playwright WebKit). After the fix, Safari sessions capture 146+ mutations where previously they captured zero.