Skip to content

Test for empty label#10

Draft
Logerfo wants to merge 1 commit intorsarky:masterfrom
Logerfo:patch-1
Draft

Test for empty label#10
Logerfo wants to merge 1 commit intorsarky:masterfrom
Logerfo:patch-1

Conversation

@Logerfo
Copy link
Copy Markdown

@Logerfo Logerfo commented Oct 29, 2019

This test is useful, since it allows users to define empty labels, as the following:

merged: ''

Source.

Empty labels will not be added to/removed from the issue.

I did this because I want to use this bot only for the "opened" label.

The diff is weird if you don't pay enough attention to it, but all I did was enclose the promises with conditionals.

In draft stage because it tests are lacking.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2019

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          53     59    +6     
  Branches        5     11    +6     
=====================================
+ Hits           53     59    +6
Impacted Files Coverage Δ
src/pull-handler.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65315d...602d612. Read the comment docs.

@Logerfo
Copy link
Copy Markdown
Author

Logerfo commented Oct 29, 2019

@rsarky do you know how we could add unit tests for this cases? It needs to use a specific config file for each test.

@rsarky
Copy link
Copy Markdown
Owner

rsarky commented Nov 18, 2019

Hey @Logerfo. Sorry for the late response, busy with some course work atm.
This feature seems pretty useful, I will give the PR a look next weekend. Thanks for contributing 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants