fix: don't register full_screen Shiny input for non-full-screen cards#1321
Draft
elnelson575 wants to merge 2 commits into
Draft
fix: don't register full_screen Shiny input for non-full-screen cards#1321elnelson575 wants to merge 2 commits into
elnelson575 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1305.
card(id = "my_card")was registeringinput$my_card_full_screeneven whenfull_screen = FALSE(the default), becausebslib-card-inputwas added to any card with anid. This caused unexpected inputs to appear in bookmarking workflows.Root cause:
is_shiny_input <- !is.null(id)— the class was gated only on whetheridwas provided, not on whether the card actually has full-screen capability.Fix:
is_shiny_input <- !is.null(id) && full_screen. Sincebslib-card-input's sole purpose is to trigger_full_screenShiny input registration in JS, it should only be applied when the card can actually go full screen.