Keep notebook Markdown within the visible pane - #375
Conversation
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c10794d994
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13397b899f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
|
@codex review CI caught a real interaction bug after all ten desktop geometry assertions passed: activating an inactive Markdown cell stole focus from the nested code scroller before the arrow key. The recording shows the rendered cell wrapper focused instead of the code block. Commit 8d66f24 preserves an already-focused descendant during automatic focus restoration. Two new activation regression tests (code and table) failed before this fix and pass afterward. All 96 focused tests pass. Please review this focus-restoration change; the previous review findings remain addressed. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
The latest CI run passes all 24 horizontal-rendering assertions, including keyboard scrolling at both 1280px and 900px. I inspected the narrow-width code/output screenshots: the focused code scroller remains inside the pane, long output wraps, and the sibling Markdown cell stays bounded. All other functional scenarios passed. The remaining two failures were Jupyter recording finalization: ffmpeg received no usable MJPEG stream and produced no movie. The Jupyter kernel setup, shared state, output, and stop assertions all passed. The browser workflow is being rerun without changing the reviewed code or weakening assertions. |
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
|
@codex review Please review the final delta in 559a1f0, especially the CI-only FFmpeg compatibility shim. The full suite twice passed all 24 horizontal-rendering assertions and every Jupyter functional assertion, but Jupyter video finalization failed with FFmpeg unable to determine MJPEG dimensions. Agent-browser 0.21.2 passes |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Problem and behavior
A wide table, fenced command, or output could expand Radix's fit-content wrapper and make every Markdown paragraph wrap beyond the visible notebook pane. The reported notebook had a 890px viewport but a 5923px column.
Constrain the notebook's generated content wrapper to the available viewport. Prose, inline identifiers, and plain-text outputs wrap; wide tables and fenced code scroll in their own keyboard-focusable regions. Other ScrollAreas retain their existing behavior. Code blocks have one scrollbar and one layer of padding. Automatic cell focus restoration preserves the focused nested scroller, so keyboard scrolling also works when activating an inactive cell.
Design and regression coverage
docs-dev/cujs/horizontal-rendering.mdand comments beside the CSS override.Validation
runme run build testpassed on the final PR head; focused Actions/MarkdownCell suites passed all 96 tests (plus 7 console tests in the required command).The browser CUJ exposed a focus-restoration bug; two new regression tests fail before the fix and pass afterward. The rendering scenario passes all 24 CI assertions.
Two full CI runs encountered the same Jupyter video-finalization failure after its functional checks passed: FFmpeg 6 could not determine the streamed JPEG dimensions. A CI-only compatibility wrapper restores normal buffering/probing for agent-browser 0.21.2's MJPEG input. Video and scenario assertions remain enabled. Local real-JPEG encoding passed with whole-frame, 32-byte, and 4096-byte pipe writes; the complete Ubuntu CI workflow passes on the final commit.
Final validation: all 108 browser assertions passed across 10 scenarios, including all 24 horizontal-rendering assertions and 19 Jupyter assertions. Verified the Jupyter artifact is a valid 28-second VP8 video and visually inspected the final narrow rendering screenshot. Both GitHub workflows pass. The final Codex review of
559a1f0found no additional major issues; all review threads are resolved.