fix(ci): support Python 3.10 in check_git_deps import - #106
Open
deanq wants to merge 1 commit into
Open
Conversation
tomllib is stdlib only on 3.11+, so scripts/check_git_deps.py raised ModuleNotFoundError on the 3.10 test matrix leg. Because docker-validation depends on the test job, this reddened every push to main since the check landed (#104) — blocking release-please and all image publishes, so the SLS-377 torchvision fix (#101) and later merges never shipped. PR CI only runs 3.11/3.12, so it passed review; push-to-main runs the full 3.10-3.14 matrix and caught it. Guard the import with a tomli backport for <3.11 and add tomli to the dev group under the same marker.
jhcipar
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/check_git_deps.pydoes an unconditionalimport tomllib.tomllibis stdlib only on Python 3.11+, so on the 3.10 test-matrix leg the module fails to import:docker-validationdepends on thetestjob, andrelease+ everydocker-prod-*publish job is gated ondocker-validation. So this one 3.10 failure has reddened every push tomainsince the check landed (#104, 2026-07-28) and blocked release-please from cutting a release — meaning no base image has published since v1.4.4 (April). The SLS-377 torchvision fix (#101, merged 7/10) and later merges (e.g. SLS-360#100) are stuck behind it.It slipped review because PR CI only runs the 3.11/3.12 matrix, while push-to-
mainruns the full 3.10–3.14 matrix.Fix
tomllibon 3.11+,tomli(drop-in backport) on <3.11.tomli>=2.0.0; python_version < '3.11'to the dev dependency group so it's present in the 3.10 env.No behavior change —
tomliexposes the sameloads/TOMLDecodeErrorAPI the script uses.Test plan
Reproduced and verified under Python 3.10.17 (the failing leg):
pytest tests/unit/test_check_git_deps.py→ModuleNotFoundError: No module named 'tomllib'(collection error), matching CI.check_git_depstests 10 passed; full suite 293 passed @ 81% coverage;ruff checkclean;ruff format --checkclean;mypyclean;python scripts/check_git_deps.pyexits 0.tomllibpath): green.Unblocks a release, which republishes
runpod/flash:latest/py3.12-latestwithtorchvision 0.24.1+cu128and closes SLS-377.