feat: AE-835 Add class based execution [Runtime] - #8
Merged
Conversation
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
pandyamarut
marked this pull request as draft
July 15, 2025 17:22
pandyamarut
marked this pull request as ready for review
July 15, 2025 17:23
deanq
requested changes
Jul 18, 2025
Collaborator
There was a problem hiding this comment.
Add a new file, test_input_class.json
{
"input": {
"execution_type": "class",
"class_name": "TestClass",
"class_code": "class TestClass:\n def __init__(self, value):\n self.value = value\n \n def get_value(self):\n return f'Value is: {self.value}' ",
"method_name": "get_value",
"constructor_args": [
"gAWVCQAAAAAAAACMBWhlbGxvlC4="
],
"constructor_kwargs": {},
"args": [],
"kwargs": {},
"create_new_instance": true
}
}
...that way we can test functionality with a class payload
deanq
requested changes
Jul 18, 2025
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
Collaborator
|
Check again. Logger.de() would error. Don't rush your commits. |
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
deanq
requested changes
Jul 22, 2025
deanq
left a comment
Collaborator
There was a problem hiding this comment.
Since we're introducing more complexity with the class-based execution, let's have unit test coverage on this. Under tests, there's integration and unit.
deanq
reviewed
Jul 23, 2025
deanq
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a modular class-based execution that extends the existing function execution capabilities. The core change allows remote execution of class methods with persistent instance management across multiple calls.
Key Methods:
execute_class_method(): Main orchestrator that handles class method execution._get_or_create_instance(): Instance lifecycle either reuses existing class instances or creates new ones based on request parameters.cleanup_instances(): removes stale instances based on configurable timeouts.