Pin ComfyUI to 0.29.0, build with CUDA 12.8, expand allowed CUDA versions to 12.8–13.3 - #231
Merged
Madiator2011Work merged 4 commits intoAug 5, 2026
Conversation
…ions - Pin COMFYUI_VERSION to 0.29.0 (latest stable) instead of latest for reproducible builds - Move default base image to nvidia/cuda:12.8.1-cudnn-runtime-ubuntu24.04 - Install ComfyUI with --cuda-version 12.8 so comfy-cli pulls current PyTorch from the cu128 index - Allow CUDA 12.8-13.3 hosts in hub.json (driver >= 570 required by cu128 wheels; newer drivers are backward compatible) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…, add changeset The venv that actually runs ComfyUI (/opt/venv) got torch from default PyPI via the requirements mirror step - and PyPI torch >= 2.11 ships CUDA 13 builds (nvidia-*-cu13 deps) requiring driver >= 580. That crashes on hosts advertising CUDA 12.8/12.9 (driver 570/575), which hub.json now allows. Installing torch 2.11.0+cu128 first satisfies ComfyUI's bare torch requirement so the PyPI pass leaves it alone; cu128 runs on driver >= 570, i.e. every allowed host. Also pin comfy-cli (reproducibility), sync the disabled tests_.json CUDA allowlist so it can't reintroduce the dead 12.6/12.7 pool if re-enabled, and add a changeset since releases are cut via changesets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
12.8 and 13.0 are where ADA_24 stock actually is today, and 13.0 is the highest version we can empirically validate. Extend the list as newer host CUDA versions are verified. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Madiator2011Work
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
0.29.0(latest stable release, 2026-07-29) instead oflatest, so builds are reproducible and don't silently change between deploys. comfy-cli is also pinned (1.13.0) for the same reason.nvidia/cuda:12.6.3-cudnn-runtime-ubuntu24.04tonvidia/cuda:12.8.1-cudnn-runtime-ubuntu24.04(Dockerfile defaults +docker-bake.hclglobals).2.11.0+cu128: the venv that actually runs ComfyUI (/opt/venv) previously got its torch from default PyPI via the requirements mirror step — and PyPI torch ≥ 2.11 ships CUDA 13 builds (nvidia-*-cu13deps) that require driver ≥ 580. That's incompatible with hosts advertising CUDA 12.8/12.9 (driver 570/575) and is likely the source of the current torch-related worker failures. Installingtorch==2.11.0+cu128before the mirror step satisfies ComfyUI's baretorchrequirement, so the runtime torch is now a known cu128 build that runs on driver ≥ 570..runpod/hub.json:allowedCudaVersionsupdated from["12.7", "12.6"]to["12.8", "12.9", "13.0"]. The disabled.runpod/tests_.jsonis synced to the same list.minor) so the change ships with the next release cut.Validated on real hosts (2026-07-30)
This exact build (base target, PR Dockerfile defaults) was pushed to a test registry and run as a serverless endpoint pinned to each CUDA version, one job per host type:
Additional validation notes:
minCudaVersionif hub.json gains support for it — floor-only semantics avoid this ceiling maintenance entirely).12.6/12.7list is nearly dead capacity-wise (zero community-cloud 4090 stock, Low secure on 12.7 only); current ADA_24 stock is concentrated on 12.8 and 13.0 hosts, so this change is a strict capacity improvement and unlocks community cloud.Known limitations / follow-ups
comfy --install's workspace venv (/comfyui/.venv) still receives its own unused torch (~5–7 GB installed). Removing it is a follow-up image-size win, left out here to keep this change low-risk.base-cuda12-8-1bake target now produces nearly the same image asbase(both end with a cu128 runtime torch). Left untouched sincerelease.yml/manual-build-all.ymlreference it by name; consolidating is a follow-up.Verification (build-time)
torch==2.11.0+cu128/torchvision==0.26.0+cu128/torchaudio==2.11.0+cu128cp312 manylinux wheels confirmed present on the cu128 index (it caps at 2.11.0 — newer torch is cu129/cu13x only).transformers>=4.50.3,<5/huggingface-hub<1.0pins (DR-1170);--quick-test-for-ci --cpuflags still exist in 0.29.0, so the build-time smoke test keeps catching startup-breaking deps.--version 0.29.0resolves the tag by string construction in comfy-cli — no GitHub API call, removing the rate-limit risk thatlatestresolution carries.🤖 Generated with Claude Code