Bump ComfyUI to 0.34.0; fix Docker Hub description sync for org tokens - #238
Open
lukepiette wants to merge 3 commits into
Open
Bump ComfyUI to 0.34.0; fix Docker Hub description sync for org tokens#238lukepiette wants to merge 3 commits into
lukepiette wants to merge 3 commits into
Conversation
Pin ComfyUI 0.34.0 in Dockerfile and docker-bake.hcl (was 0.29.0). Replace peter-evans/dockerhub-description (legacy Hub API, rejects organization access tokens) with a direct PATCH to the namespaces endpoint, and move GitHub release creation ahead of it so a description failure can't abort the release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The image bundles its own CUDA 12.8 runtime; hosts advertising newer CUDA versions satisfy the driver floor and run it unchanged. Without these entries, endpoints were locked out of hosts reporting 13.1/13.2 (most RTX 5090 and RTX PRO 6000 capacity). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ComfyUI pin (0.29.0 → 0.34.0). Workflows exported from current ComfyUI use core nodes that don't exist in older runtimes and fail at execution with "missing node" errors. This is breaking comfyui-wizard (comfy.getrunpod.io), which builds every generated image
FROM runpod/worker-comfyui:*-base. ComfyUI's dependency floors are unchanged between 0.29.0 and 0.34.0 (sametransformers>=4.50.3, baretorch), so the existingtorch==2.11.0+cu128andtransformers<5/huggingface-hub<1pins still apply, and the build-time ComfyUI startup smoke test gates the release.Release workflow fix.
peter-evans/dockerhub-descriptionauthenticates via Docker Hub's legacy user-login API (/v2/users/login+ legacy/v2/repositories/...), which rejects organization access tokens unconditionally — per Docker's docs, legacy paths refuse every OAT regardless of scopes. Since the credential rotation to an org token, this step 401s on every release and abortspost-releasebefore the GitHub release is created (5.9.0's release/tag had to be backfilled manually). Replaced with a directPATCH https://hub.docker.com/v2/namespaces/{ns}/repositories/{repo}using the sameDOCKERHUB_TOKENas a Bearer token (a supported OAT endpoint), and movedgh release createabove it so a description failure can never block a release again.Changes
Dockerfile,docker-bake.hcl:COMFYUI_VERSION0.29.0 → 0.34.0.github/workflows/release.yml: reorder GitHub-release step ahead of description sync; swap the description action for a curl to the namespaces endpointValidation
requirements.txtdiffed across v0.29.0/v0.30.0/v0.34.0 — no floor changes affecting the image's pinned deps.Follow-ups (separate, comfyui-wizard repo)
Bump the wizard's
BASE_IMAGE(lib/parser/dockerfile.ts) to the release this produces and regeneratebuiltin-nodes.jsonfrom the new image's/object_info— the wizard misclassifies post-0.16.4 core nodes until that list is refreshed.🤖 Generated with Claude Code