feat: AE-815 Add class based execution - #72
Merged
Conversation
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
deanq
requested changes
Jul 18, 2025
deanq
left a comment
Member
There was a problem hiding this comment.
Either write unit and integration tests or write a working tetra-example to flush out any unforeseen bugs
Comment on lines
+55
to
+56
| print(f"Warning: Could not extract class code for {cls.__name__}: {e}") | ||
| print("Falling back to basic class structure") |
Member
|
Be sure to run make check after all your changes. You can ignore the mypy warnings. We can address those later. They don't block CI/CD for now. |
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
deanq
requested changes
Jul 22, 2025
deanq
left a comment
Member
There was a problem hiding this comment.
Please add a tests/integration/test_class_execution_integration.py since these changes are crucial and complex. We want to keep this durable. Some test suggestions I can think of:
- Test remote class decorator integration
- Test multiple method calls on the same instance
- Test class with complex constructor arguments
- Test error handling in remote class execution
Comment on lines
+55
to
+56
| print(f"Warning: Could not extract class code for {cls.__name__}: {e}") | ||
| print("Falling back to basic class structure") |
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
deanq
approved these changes
Jul 22, 2025
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
This vLLM example demonstrates the key benefits: the BasicLLM class loads the model once in init(), then the generate() method can be called multiple times with different prompts, all using the same GPU model. The instance persists between calls, maintaining both the loaded model and any internal state, making it essential for production ML services that need both performance and statefulness.