feat: always send product with catalog availability requests - #84
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
justinwlin
self-requested a review
August 14, 2026 22:56
justinwlin
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next v2 API release makes
productrequired withinclude=AVAILABILITYon the catalog GPU endpoints (400 without it).list-gpu-typesandget-gpu-typenow always send it, via a new optionalproductparam (POD | CLUSTER | SERVERLESS, default POD), omitted whenincludeAvailabilityis false since the API also rejectsproductwithout the include. CPU catalog tools never request availability, so they're unchanged.Note: refreshing the vendored spec fixture (
pnpm tsx scripts/fetch-v2-spec.ts) trips the parity gate on 9 uncovered dev endpoints (ssh-keys, clusters, catalog/templates) — left for a separate PR, fixture untouched here.Test plan:
pnpm test(697 pass) including new URL assertions for product pass-through, omission without availability, and junk-value fallback;pnpm type-checkandpnpm lintclean.