Expose configured base URL on Builder (closes #128) - #240
Open
gghez wants to merge 1 commit into
Open
Conversation
Adds three Builder accessors that mirror the existing is_url_relative_deny / is_url_relative_pass_through / is_url_relative_custom introspection methods so callers can inspect the relative-URL configuration without re-deriving it: * is_url_relative_rewrite_with_base * is_url_relative_rewrite_with_root * url_relative_base -> Option<&Url> Closes rust-ammonia#128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three small introspection methods on
Builderthat mirror the existingis_url_relative_deny/is_url_relative_pass_through/is_url_relative_custompattern, so callers can inspect (or recover) the relative-URL configuration without re-deriving it:is_url_relative_rewrite_with_base() -> boolis_url_relative_rewrite_with_root() -> boolurl_relative_base() -> Option<&Url>— returns the baseUrlwhenUrlRelative::RewriteWithBaseis configuredThis addresses the "expose a function returning the set base value or none" half of #128. No behavior change for existing users; only new public accessors.
Test plan
cargo test(all unit + doc tests pass, including the three new doctests)master