Replace lazy_static with OnceLock and set rust-version#139
Open
smoe wants to merge 1 commit into
Open
Conversation
smoe
force-pushed
the
remove-lazystatic-dependency
branch
from
March 27, 2026 15:57
245e923 to
0612e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had this dependency on lazy_static in my local project and traced that to rust-bio, and from there to rust-bio-types.
The minimal rust-version for OnceLock (https://doc.rust-lang.org/beta/std/sync/struct.OnceLock.html) is 1.70, which likely is ok since rust-bio declares 1.82 as its minimal version. LazyLock would be with 1.80. So most likely OnceLock is the modernisation path with the least impact on the minimal version of rust required.
Disclaimer: I had OpenAI Codex create this patch for me. From what see and read about about it, it looks fine.