Skip to content

allow setting global alert from the database / CLI#3274

Open
syphar wants to merge 3 commits intorust-lang:mainfrom
syphar:custom-warning
Open

allow setting global alert from the database / CLI#3274
syphar wants to merge 3 commits intorust-lang:mainfrom
syphar:custom-warning

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Apr 2, 2026

I want to be able to set / remove the global alert without having to recompile / deploy.

Cases for this probably:

  • queue length (I might automate this warning at some point)
  • potential reduction of default targets due to build capacity (separate discussion, probably blog article & survey first?)

We cache the value for 5 minutes, so we won't have too many added database queries.

It will look like this, and be a link to the given link:
image

@syphar syphar self-assigned this Apr 2, 2026
@syphar syphar requested a review from a team as a code owner April 2, 2026 19:40
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 2, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

I think you're trying to fix two different problems here:

  1. docs.rs issues
  2. docs.rs changes

The first one needs to be there as long as the issue(s) are there. The second one being a notice, it should be discard-able by the user and attract attention a lot more. So your PR fits well for 1., but doesn't for 2. imo. 2. should most likely be a static element floating over the content.

What do you think?

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 4, 2026

I admit I didn't think much further than just making the old feature not hardcoded, so we can start showing something somewhere.

I don't think I can build either of the other approaches in the next week, but hopefully some time after that, depending on many other factors.

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 4, 2026

I think you're trying to fix two different problems here:

1. docs.rs issues

2. docs.rs changes

The first one needs to be there as long as the issue(s) are there. The second one being a notice, it should be discard-able by the user and attract attention a lot more. So your PR fits well for 1., but doesn't for 2. imo. 2. should most likely be a static element floating over the content.

What do you think?

Right now I don't have an opinion on that (too tired / sick), how does crates.io do it?

Generally what you propose feels like it makes sense.

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 4, 2026

general thought:

with my dayjob problems right now, I don't think I can spend time on any of the proposed other things in the next week or two (except when I'm lucky, not sure).

so I'm asking myself if we should use this first to make people aware of the new default-target change first?

@GuillaumeGomez
Copy link
Copy Markdown
Member

I can take over this PR and implement the missing parts if you want?

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 7, 2026

I can take over this PR and implement the missing parts if you want?

thanks for the offer!

My hunch is that you're right generally, but I want to think it through first when I'm a little better.

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 7, 2026

( will set the compiled-in warning in a separate PR for the current change only)

@GuillaumeGomez
Copy link
Copy Markdown
Member

Sounds good to me. :)

@rustbot

This comment has been minimized.

@syphar syphar force-pushed the custom-warning branch 2 times, most recently from e2b4f07 to 0bc9736 Compare April 7, 2026 21:51
@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 7, 2026

@GuillaumeGomez I had another idea about multiple alerts, the separate page looked so empty with the information that was there..

what do you think?
image

It would collapse (so no dropdown) when there is only one alert.

Also now there is an example how the webserver now collects metrics from the builder-lib.

( not sure if I was too much into it and overengineered 😅 )

@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented Apr 7, 2026

Well, I was kinda hoping to provide more information for each anomaly on the page. 😆

Like since how long it's happening, what's the impact to users, etc.

@rustbot

This comment has been minimized.

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 8, 2026

Well, I was kinda hoping to provide more information for each anomaly on the page. 😆

Like since how long it's happening, what's the impact to users, etc.

Want to add a commit how you would imagine it?

@GuillaumeGomez
Copy link
Copy Markdown
Member

I can try. :)

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 8, 2026

I just rebased to fix the conflicts, will leave it alone now @GuillaumeGomez

@GuillaumeGomez
Copy link
Copy Markdown
Member

I added the draft for the status page of docs.rs. It looks like this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants