Skip to content

Improve suggestion for $-prefixed fragment specifiers#155643

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
qaijuang:fix-macro-missing-fragment-dollar-suggestion
Apr 25, 2026
Merged

Improve suggestion for $-prefixed fragment specifiers#155643
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
qaijuang:fix-macro-missing-fragment-dollar-suggestion

Conversation

@qaijuang
Copy link
Copy Markdown
Contributor

@qaijuang qaijuang commented Apr 22, 2026 •
edited by rustbot
Loading

Fixes #155505

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2026
@qaijuang qaijuang marked this pull request as ready for review April 22, 2026 13:38
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@qaijuang qaijuang force-pushed the fix-macro-missing-fragment-dollar-suggestion branch from e793044 to af8e234 Compare April 24, 2026 18:46
@qaijuang qaijuang changed the title Suggest removing accidental $ before fragment specifier Improve suggestion for $-prefixed fragment specifiers Apr 24, 2026
@qaijuang qaijuang force-pushed the fix-macro-missing-fragment-dollar-suggestion branch from af8e234 to 2b46d92 Compare April 24, 2026 19:01
@eholk
Copy link
Copy Markdown
Contributor

eholk commented Apr 24, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit 2b46d92 has been approved by eholk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 25, 2026
@jhpratt
Rollup merge of rust-lang#155643 - qaijuang:fix-macro-missing-fragmen…
c4ff64b 
…t-dollar-suggestion, r=eholk

Improve suggestion for $-prefixed fragment specifiers

Fixes rust-lang#155505
This was referenced Apr 25, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
@bors
Auto merge of #155766 - jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f 
Rollup of 7 pull requests

Successful merges:

 - #155643 (Improve suggestion for $-prefixed fragment specifiers)
 - #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
 - #154372 (Exposing Float Masks)
 - #155680 (Handle index projections in call destinations in DSE)
 - #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
 - #155737 (Account for `GetSyntheticValue` failures)
 - #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors rust-bors Bot merged commit d3eddcf into rust-lang:main Apr 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 25, 2026
rust-timer added a commit that referenced this pull request Apr 25, 2026
@rust-timer
Unrolled build for #155643
10f9f93 
Rollup merge of #155643 - qaijuang:fix-macro-missing-fragment-dollar-suggestion, r=eholk

Improve suggestion for $-prefixed fragment specifiers

Fixes #155505
@qaijuang qaijuang deleted the fix-macro-missing-fragment-dollar-suggestion branch April 25, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eholk eholk eholk approved these changes

Assignees

@eholk eholk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

Macro "missing fragment specifier" when accidentally prefixed with $

3 participants

@qaijuang @rustbot @eholk