Skip to content

Rollup of 3 pull requests#155755

Merged
rust-bors[bot] merged 7 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-oG1Wz3V
Apr 25, 2026
Merged

Rollup of 3 pull requests#155755
rust-bors[bot] merged 7 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-oG1Wz3V

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented Apr 24, 2026

Successful merges:

r? @ghost

Create a similar rollup

folkertdev and others added 7 commits April 19, 2026 18:27
@folkertdev
add MaybeUninit to minicore
aa38b7f
@folkertdev
cmse: test returning MaybeUninit<T>
640c4b4 
The `MaybeUninit` type is `repr(transparent)`, so returning a `MaybeUninit<u64>` should work. The same is not true when using C or rust union types.
@xtqqczze
std: Refactor flush method in BufWriter to use the ? operator
15e60eb
@folkertdev
make the core::ffi::va_list module private
3851c60 
the types are exported from `core::ffi` itself
@JonathanBrouwer
Rollup merge of rust-lang#155754 - folkertdev:hide-core-ffi-va-list, …
6d6b99e 
…r=tgross35

make the `core::ffi::va_list` module private

tracking issue: rust-lang#44930

the types are exported from `core::ffi` itself.

T-libs-api decided that we should only export the types from `core::ffi`, and should not make `core::ffi::va_list` public, see rust-lang#44930 (comment).

r? tgross35
@JonathanBrouwer
Rollup merge of rust-lang#155522 - folkertdev:cmse-test-maybe-uninit,…
39d8424 
… r=WaffleLapkin

cmse: test returning `MaybeUninit<T>`

tracking issue: rust-lang#81391
tracking issue: rust-lang#75835

Some tests from rust-lang#147697 that already work and are useful. Extracting them shrinks that (currently blocked) PR.

The code in `tests/ui/cmse-nonsecure/cmse-nonsecure-call/return-via-stack.rs` checks that `MaybeUninit<T>` is considered abi-compatible with `T`. The code in `tests/ui/cmse-nonsecure/cmse-nonsecure-entry/params-via-stack.rs` really only tests that no errors/warnings are emitted.

r? davidtwco
@JonathanBrouwer
Rollup merge of rust-lang#155741 - xtqqczze:question-mark-bufwriter-f…
6f536cf 
…lush, r=WaffleLapkin

std: Refactor BufWriter::flush to use the `?` operator

Functionally, this is equivalent and may     be slightly more amenable to inlining.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Apr 24, 2026
@rustbot rustbot added A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 24, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit 6f536cf has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 25, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 14m 38s
Pushing 597d9e4 to main...

@rust-bors rust-bors Bot merged commit 597d9e4 into rust-lang:main Apr 25, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 25, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 25, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#155522 cmse: test returning MaybeUninit<T> c9a2ae0f9781ddfc7c87c5eb387771688f48101a (link)
#155741 std: Refactor BufWriter::flush to use the ? operator d652407977241d4300a27a859550c6b96847b4cb (link)
#155754 make the core::ffi::va_list module private 50bf78e3a63a9cf80e377272cf56331e0b04505b (link)

previous master: 80729d7ce0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 80729d7 (parent) -> 597d9e4 (this PR)

Test differences

Show 6 test diffs

6 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 597d9e43be882cdbd218e58c4f7efb2fa3da7540 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. i686-gnu-nopt-1: 1h 49m -> 2h 24m (+31.1%)
  2. x86_64-gnu-debug: 2h 10m -> 1h 36m (-25.9%)
  3. dist-x86_64-illumos: 1h 45m -> 1h 22m (-21.5%)
  4. dist-android: 28m 7s -> 22m 49s (-18.8%)
  5. arm-android: 1h 28m -> 1h 44m (+17.5%)
  6. tidy: 2m 45s -> 2m 17s (-17.0%)
  7. dist-powerpc64-linux-gnu: 1h 30m -> 1h 15m (-16.5%)
  8. pr-check-1: 29m 23s -> 34m 12s (+16.4%)
  9. x86_64-gnu-nopt: 2h 16m -> 1h 53m (-16.3%)
  10. dist-apple-various: 1h 31m -> 1h 46m (+16.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Apr 25, 2026
Open
Open
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 25, 2026

Finished benchmarking commit (597d9e4): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 6.4% [1.7%, 8.7%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -6.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.8% [-6.8%, -6.8%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 492.349s -> 489.989s (-0.48%)
Artifact size: 394.32 MiB -> 394.31 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rust-timer @rustbot @folkertdev @xtqqczze