Modified oncomplete so it returns the object it was tweening#5
Open
Edrem wants to merge 2 commits into
Open
Conversation
This small change makes it very easy to chain together tweens and create repeats. For example.
local function tweenRepeat(obj)
Flux.to(obj, 4, {x = 10}):after(4, {x = 0}):oncomplete(tweenRepeat)
end
tweenRepeat(obj)
|
Thanks! This tiny modification makes it 10x more convenient to use. You don't need to create anonymous functions in your tween calls everywhere. One small tweak still needs to be made to line 62 though, so it works if you stack multiple -- Your version: The second oncomplete function call: x() doesn't get the object.
self[field] = old and function() old(self.obj) x() end or xI just did this: self[field] = old and function(...) old(...) x(...) end or xIn case I ever want to edit things again to send more arguments to any of the callbacks, it should always work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: My initial pull request was broken, fixed a small error when using :after and :oncomplete
This small change makes it very easy to chain together tweens and create repeats. For example.
local function tweenRepeat(obj)
Flux.to(obj, 4, {x = 10}):after(4, {x = 0}):oncomplete(tweenRepeat)
end
tweenRepeat(FanceObject:new())