perf: discard oversized query bookkeeping tables - #1236
Open
MichaReiser wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
marked this pull request as ready for review
July 6, 2026 17:12
Merging this PR will improve performance by 40.03%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
MichaReiser
force-pushed
the
fix/discard-sparse-query-capacity
branch
from
July 9, 2026 19:45
258b321 to
ad26bd3
Compare
MichaReiser
force-pushed
the
fix/discard-sparse-query-capacity
branch
from
August 1, 2026 12:36
ad26bd3 to
0dcc897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexMapclears retained hash control bytes inO(capacity), making sparse query (like 2 edges) frames expensive after a large query.Ideally, this would be something that
HashTablehandles better. For now, we'll drop the allocation if we've seen one overly largeIndexMapthat is only very sparsely populated. Specifically, we preserve up to 2x slack above a 16K floor.Testing: ty shows a 0.77% static-frame improvement.