Skip to content

chore: fix cascading reparses in the lazy-input example - #1256

Open
hardfist wants to merge 1 commit into
salsa-rs:masterfrom
hardfist:agent/fix-lazy-input-tracked-fields
Open

chore: fix cascading reparses in the lazy-input example#1256
hardfist wants to merge 1 commit into
salsa-rs:masterfrom
hardfist:agent/fix-lazy-input-tracked-fields

Conversation

@hardfist

@hardfist hardfist commented Jul 17, 2026

Copy link
Copy Markdown

Mark ParsedFile::value and ParsedFile::links as #[tracked] so changing a leaf input no longer changes parent identities and triggers cascading reparses.

This completes the lazy-input example's migration to coarse-grained tracked structs introduced in #657.

@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 1e91509
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/6a5a175712095100083a0899

@hardfist hardfist changed the title Fix cascading reparses in the lazy-input example chore: Fix cascading reparses in the lazy-input example Jul 17, 2026
@hardfist hardfist changed the title chore: Fix cascading reparses in the lazy-input example chore: fix cascading reparses in the lazy-input example Jul 17, 2026
@hardfist
hardfist force-pushed the agent/fix-lazy-input-tracked-fields branch from e32793a to 1e91509 Compare July 17, 2026 11:51
@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 30.87%

⚡ 1 improved benchmark
✅ 73 untouched benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime parallel_fast_path[NoEviction] 472.7 µs 361.2 µs +30.87%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing hardfist:agent/fix-lazy-input-tracked-fields (1e91509) with master (a79c456)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@hardfist
hardfist marked this pull request as ready for review July 17, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant