Conversation
Iteritems was droppped in Python 3 so making sure the code still works.
Under normal circumstances, you don't need to specify user, as the provided service file specifies the user.
The defaults copy the default behaviour. No need to explicitly specify it.
This make passing just an user setting obsolete. There is much more to be set.
Whenever zone file changes, knot should check the zone and reload it.
Important feature for knot.conf - allow arays without quites. In pillar you specify address: '[ 192.168.1.1, 192.168.1.2]' And in resulting knot.conf, you will end up with address: [ 192.168.1.1, 192.168.1.2] If you use in pillar intuitive construction like this address: [ 192.168.1.1, 192.168.1.2] The end result is invalid address: [ '192.168.1.1', '192.168.1.2']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Little cleanup and adding zone management.