PLASMA-7776: migrate Spinner from svg to css - #3011
Open
Yakutoc wants to merge 5 commits into
Open
Conversation
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (386)
📒 Files selected for processing (70)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3011/ |
Yakutoc
changed the title
oki1oki
force-pushed
the
feat-beta-spinner
branch
from
September 1, 2026 02:17
4f9b37f to
8f88586
Compare
oki1oki
force-pushed
the
feat-beta-spinner
branch
from
September 3, 2026 00:37
8f88586 to
1c25ea2
Compare
oki1oki
changed the title
svg to css
Contributor
oki1oki
force-pushed
the
feat-beta-spinner
branch
from
September 3, 2026 01:54
1c25ea2 to
0c79bd2
Compare
oki1oki
force-pushed
the
feat-beta-spinner
branch
from
September 3, 2026 03:03
0c79bd2 to
4a89419
Compare
oki1oki
force-pushed
the
feat-beta-spinner
branch
from
September 3, 2026 03:24
4a89419 to
4b7bc85
Compare
oki1oki
marked this pull request as ready for review
September 3, 2026 04:03
oki1oki
requested review from
IgorYar
and removed request for
Yeti-or,
neretin-trike and
shuga2704
September 3, 2026 04:03
IgorYar
approved these changes
Sep 3, 2026
TitanKuzmich
reviewed
Sep 3, 2026
Comment on lines
+17
to
+21
| const customDimensions = customWidth && customHeight ? { width: customWidth, height: customHeight } : undefined; | ||
| const customSize = customDimensions | ||
| ? `min(${customDimensions.width}, ${customDimensions.height})` | ||
| : getCustomSize(size); | ||
| const customStyle: Record<string, string> = { |
Collaborator
There was a problem hiding this comment.
Тут могут же только ширину задать и тогда условие не отработает
Collaborator
There was a problem hiding this comment.
по типам width всегда с height идет
TitanKuzmich
approved these changes
Sep 3, 2026
Collaborator
|
Еще бы тесты в new-hope положить |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core
Spinner
What/why changed
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.393.0-canary.3011.33711272811.0 npm install @salutejs/plasma-b2c@1.635.0-canary.3011.33711272811.0 npm install @salutejs/plasma-colors@0.23.0-canary.3011.33711272811.0 npm install @salutejs/plasma-core@1.242.0-canary.3011.33711272811.0 npm install @salutejs/plasma-giga@0.362.0-canary.3011.33711272811.0 npm install @salutejs/plasma-homeds@0.362.0-canary.3011.33711272811.0 npm install @salutejs/plasma-hope@1.389.0-canary.3011.33711272811.0 npm install @salutejs/plasma-icons@1.250.0-canary.3011.33711272811.0 npm install @salutejs/plasma-new-hope@0.379.0-canary.3011.33711272811.0 npm install @salutejs/plasma-tokens@1.153.0-canary.3011.33711272811.0 npm install @salutejs/plasma-tokens-b2b@1.66.0-canary.3011.33711272811.0 npm install @salutejs/plasma-tokens-b2c@0.77.0-canary.3011.33711272811.0 npm install @salutejs/plasma-tokens-core@0.14.0-canary.3011.33711272811.0 npm install @salutejs/plasma-tokens-web@1.81.0-canary.3011.33711272811.0 npm install @salutejs/plasma-typo@0.54.0-canary.3011.33711272811.0 npm install @salutejs/plasma-web@1.637.0-canary.3011.33711272811.0 npm install @salutejs/sdds-bizcom@0.367.0-canary.3011.33711272811.0 npm install @salutejs/sdds-cs@0.371.0-canary.3011.33711272811.0 npm install @salutejs/sdds-dfa@0.365.0-canary.3011.33711272811.0 npm install @salutejs/sdds-finai@0.358.0-canary.3011.33711272811.0 npm install @salutejs/sdds-icons@0.7.0-canary.3011.33711272811.0 npm install @salutejs/sdds-insol@0.362.0-canary.3011.33711272811.0 npm install @salutejs/sdds-insol-next@0.361.0-canary.3011.33711272811.0 npm install @salutejs/sdds-netology@0.366.0-canary.3011.33711272811.0 npm install @salutejs/sdds-os@0.37.0-canary.3011.33711272811.0 npm install @salutejs/sdds-platform-ai@0.366.0-canary.3011.33711272811.0 npm install @salutejs/sdds-sbcom@0.367.0-canary.3011.33711272811.0 npm install @salutejs/sdds-scan@0.365.0-canary.3011.33711272811.0 npm install @salutejs/sdds-serv@0.366.0-canary.3011.33711272811.0 npm install @salutejs/core-themes@0.42.0-canary.3011.33711272811.0 npm install @salutejs/plasma-themes@0.64.0-canary.3011.33711272811.0 npm install @salutejs/sdds-themes@0.80.0-canary.3011.33711272811.0 npm install @salutejs/sdds-api-tests@0.24.0-canary.3011.33711272811.0 npm install @salutejs/plasma-cy-utils@0.172.0-canary.3011.33711272811.0 npm install @salutejs/plasma-sb-utils@0.243.0-canary.3011.33711272811.0 npm install @salutejs/plasma-tokens-utils@0.62.0-canary.3011.33711272811.0 # or yarn add @salutejs/plasma-asdk@0.393.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-b2c@1.635.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-colors@0.23.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-core@1.242.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-giga@0.362.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-homeds@0.362.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-hope@1.389.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-icons@1.250.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-new-hope@0.379.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-tokens@1.153.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-tokens-b2b@1.66.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-tokens-b2c@0.77.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-tokens-core@0.14.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-tokens-web@1.81.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-typo@0.54.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-web@1.637.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-bizcom@0.367.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-cs@0.371.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-dfa@0.365.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-finai@0.358.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-icons@0.7.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-insol@0.362.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-insol-next@0.361.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-netology@0.366.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-os@0.37.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-platform-ai@0.366.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-sbcom@0.367.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-scan@0.365.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-serv@0.366.0-canary.3011.33711272811.0 yarn add @salutejs/core-themes@0.42.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-themes@0.64.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-themes@0.80.0-canary.3011.33711272811.0 yarn add @salutejs/sdds-api-tests@0.24.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-cy-utils@0.172.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-sb-utils@0.243.0-canary.3011.33711272811.0 yarn add @salutejs/plasma-tokens-utils@0.62.0-canary.3011.33711272811.0