Skip to content

[codex] Improve Content-Disposition parameter parsing#10

Merged
chrislearn merged 1 commit intomainfrom
codex/content-disposition-compat
Apr 1, 2026
Merged

[codex] Improve Content-Disposition parameter parsing#10
chrislearn merged 1 commit intomainfrom
codex/content-disposition-compat

Conversation

@chrislearn
Copy link
Copy Markdown
Member

Summary

  • parse Content-Disposition parameter names case-insensitively
  • decode percent-encoded unquoted values and support filename*
  • add end-to-end coverage for the compatibility cases

Why

The old parser only matched lowercase name/filename and ignored RFC 5987-style filename* values. That caused valid or common client uploads to lose the field name or filename.

Impact

Multipart parsing becomes more compatible with real-world clients without changing the public API.

Validation

  • cargo fmt --all
  • cargo test --all --all-features
  • cargo clippy --tests --examples --bins -- -D warnings

@chrislearn chrislearn marked this pull request as ready for review April 1, 2026 15:23
@chrislearn chrislearn merged commit ea73099 into main Apr 1, 2026
2 of 3 checks passed
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chrislearn chrislearn deleted the codex/content-disposition-compat branch April 1, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant