Fix get_subdomain() redirect loop on apex domains#2121
Open
mhingston wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_subdomain()inapps/reader/views.pynaively splits the hostname on dots and returns the first segment. For apex domains likenewsblur.yourdomain.com(which contain 2+ dots), it incorrectly returnsnewsbluras a subdomain. Sincenewsblurisn't inALLOWED_SUBDOMAINSand doesn't match any username, it redirects to the same URL — causing an infinite redirect loop.Fix
Use
request.subdomainfrom theSubdomainMiddlewareinstead, which properly parses subdomains against theSitedomain and returnsNonefor apex domains. Falls back to the old logic only when the middleware hasn't set the attribute.