Pin json ~> 2.0#3095
Closed
ShanaLMoore wants to merge 1 commit into
Closed
Conversation
Test Results 3 files ±0 3 suites ±0 14m 10s ⏱️ - 1m 4s Results for commit 951fd17. ± Comparison against base commit fdd4986. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. |
maxkadel
requested changes
Jun 8, 2026
Collaborator
There was a problem hiding this comment.
Shoot, I think I was wrong about blacklight_advanced_search needing to be pinned - I think v8 should be compatible with BL 7 - it was just a specific test that failed in that one knapsack.
I do think we need the json pin, though.
| gem 'bixby', group: %i[development test] | ||
| gem 'blacklight', '~> 7.38' # Updated for Rails 7.2 compatibility | ||
| gem 'blacklight_advanced_search' | ||
| gem 'blacklight_advanced_search', '~> 7.0' # v8 introduces breaking changes |
Collaborator
There was a problem hiding this comment.
Looking into this more, I think I was wrong - I think it was an individual test for that knapsack that failed with the new version, but I think v8 should be non-breaking.
Knapsacks gitignore Gemfile.lock and re-resolve from scratch in CI, so unpinned gems can drift to incompatible majors (e.g. json 3.x). Pinning json at the Hyku level keeps every downstream resolving to a compatible version without each one overriding via bundler.d. ref: https://notch8.slack.com/archives/C08EHRPQ9MY/p1780929216187279
ShanaLMoore
force-pushed
the
pin-blacklight-advanced-search-and-json
branch
from
951fd17 to
187b83b
Compare
ShanaLMoore
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knapsacks gitignore Gemfile.lock and re-resolve from scratch in CI, so unpinned gems can drift to incompatible majors (e.g. json 3.x).
Pinning json at the Hyku level keeps every downstream resolving to a compatible version without each one overriding via bundler.d.
ref: https://notch8.slack.com/archives/C08EHRPQ9MY/p1780929216187279
@samvera/hyku-code-reviewers