Generator template files for simple ramp viewer#7417
Draft
cjcolvar wants to merge 1 commit into
Draft
Conversation
Test Results 17 files ±0 17 suites ±0 3h 29m 14s ⏱️ +37s Results for commit 102b66a. ± Comparison against base commit be91090. This pull request removes 444 and adds 444 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based upon the framework built in #7400, this PR adds the necessary files for the ramp IIIF viewer.
There are some issues/questions that need to be resolved on either the hyrax, iiif_manifest, or ramp side: