Skip to content

Generator template files for simple ramp viewer#7417

Draft
cjcolvar wants to merge 1 commit into
mainfrom
ramp-installer-subbranch
Draft

Generator template files for simple ramp viewer#7417
cjcolvar wants to merge 1 commit into
mainfrom
ramp-installer-subbranch

Conversation

@cjcolvar

Copy link
Copy Markdown
Member

Based upon the framework built in #7400, this PR adds the necessary files for the ramp IIIF viewer.

There are some issues/questions that need to be resolved on either the hyrax, iiif_manifest, or ramp side:

  • No structures in generated manifest
    • Should ramp provide a default structure based on items when one isn't provided?
  • Duration not displaying
    • Without StructuredNavigation duration displays but player never finishes loading
    • StructuredNavigation component required by ramp?
  • Do we want to display more components? (metadata, transcripts, supplemental files, etc.)
    • Changes to layout/components could come in a future PR
  • WAV files don't playback in ramp in firefox (they do in UV and clover)
    • Maybe a limitation of video.js?
  • More testing needed with a variety of audio/video files

@github-actions

Copy link
Copy Markdown

Test Results

    17 files  ±0      17 suites  ±0   3h 29m 14s ⏱️ +37s
 7 202 tests ±0   6 896 ✅ ±0  306 💤 ±0  0 ❌ ±0 
24 117 runs  ±0  23 526 ✅ ±0  591 💤 ±0  0 ❌ ±0 

Results for commit 102b66a. ± Comparison against base commit be91090.

This pull request removes 444 and adds 444 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1d8b506f40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f74457321c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd61529c5a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff3fc322308>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1d8b535ca0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f744586c958>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd6152a9750>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff3fc4108c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 89be1a6b-eaa1-4738-a02b-5a3d0c4c6970
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 1cb8c4c2-e6d4-411a-baaf-dab4cfd79078
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0581d7b058>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4005f36190>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f47bc1b3720>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fec6ed36410>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0581d81048>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4005f67448>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f47bc2a16a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fec6ebb4100>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 1f5a9c54-b253-497e-8a14-d69b44118fe0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7408c4f1-d3f2-423f-ac9e-c40a7e2e552d
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant