Try turning on valkyrie_transition in .dassie by default

[dlpierce]

Fixes

Fixes #issuenumber ; refs #issuenumber

Summary

Present tense short summary (50 characters or less)

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

• notes-major Major Changes (Potentially breaking changes)
• notes-minor New Features that are backward compatible
• notes-deprecation Deprecations
• notes-bugfix Bug Fixes
• notes-valkyrie Valkyrie Progress
• notes-docs Documentation
• notes-container Containerization related (Docker, Helm, etc)

Detailed Description

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

class PostsController
  def index
    respond_with Post.limit(10)
  end
end

Changes proposed in this pull request:

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    17 files  ± 0      17 suites  ±0   2h 19m 39s ⏱️ - 1h 8m 10s
 7 583 tests  - 13   6 661 ✅  - 628  309 💤 +3  613 ❌ +612 
25 710 runs  ± 0  24 496 ✅  - 620  600 💤 +7  614 ❌ +613 

For more details on these failures, see this check.

Results for commit 512bdad. ± Comparison against base commit ffe4b30.

This pull request removes 461 and adds 448 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0b29d83ac0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1e47b13ac0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb432328e88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc7155a08c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0b29ed4898>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1e47b32308>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb4323362e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc7155c0290>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: c465ab45-9cff-44bd-81f6-98543be4ca32
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2cb9d6cb-b44d-4b1b-b878-30b440ab5b12
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efc341da290>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f411322a640>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f84e1e3f518>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007facf4ab2d10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efc341ca8e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4113236e18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f84e1e5f3e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007facf4ae8208>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSetResource: e6cd44c6-3e3a-41de-bedf-8e2e7b44ad11
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 1a6ed58c-fc13-46df-b071-fe3bb081e850
…

This pull request skips 3 tests.

spec.forms.hyrax.forms.collection_form_spec ‑ Hyrax::Forms::CollectionForm#permission_template when the PermissionTemplate doesn't exist gets created
spec.forms.hyrax.forms.collection_form_spec ‑ Hyrax::Forms::CollectionForm#permission_template when the PermissionTemplate exists uses the existing template
spec.forms.hyrax.forms.collection_form_spec ‑ Hyrax::Forms::CollectionForm#select_files with a work/file attached returns a hash of with file title as key and file id as value

♻️ This comment has been updated with latest results.