Skip to content

feat: add SBPP_BanPlayerBySteamId native for offline player bans #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sigibert wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add SBPP_BanPlayerBySteamId native for offline player bans #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cca9c76
feat: add SBPP_BanPlayerBySteamId native for offline player bans
Sigibert Jun 27, 2026
f0c0c82
fix: validate SteamID2 format before inserting ban
Sigibert Jun 27, 2026
97ed2bf
fix: only fire SBPP_OnBanPlayer after the ban INSERT succeeds
Sigibert Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions game/addons/sourcemod/scripting/include/sourcebanspp.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public void __pl_sourcebanspp_SetNTVOptional()
{
MarkNativeAsOptional("SBBanPlayer");
MarkNativeAsOptional("SBPP_BanPlayer");
MarkNativeAsOptional("SBPP_BanPlayerBySteamId");
MarkNativeAsOptional("SBPP_ReportPlayer");
}
#endif
Expand Down Expand Up @@ -109,6 +110,20 @@ native void SBBanPlayer(int iAdmin, int iTarget, int iTime, const char[] sReason
*********************************************************/
native void SBPP_BanPlayer(int iAdmin, int iTarget, int iTime, const char[] sReason);

/*********************************************************
* Ban a player by SteamID — supports offline/disconnected players.
* Inserts the ban directly into the SourceBans++ database.
* Fires SBPP_OnBanPlayer with iTarget = -1 to indicate an offline ban.
*
* @param iAdmin Client index of the admin (0 = server / automated)
* @param steamId SteamID string, e.g. "STEAM_0:0:12345"
* @param name Player name; may be empty string if unknown
* @param iTime Ban duration in minutes (0 = permanent)
* @param sReason Reason for the ban
* @noreturn
*********************************************************/
native void SBPP_BanPlayerBySteamId(int iAdmin, const char[] steamId, const char[] name, int iTime, const char[] sReason);

/*********************************************************
* Reports a player
*
Expand Down
143 changes: 143 additions & 0 deletions game/addons/sourcemod/scripting/sbpp_main.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ public APLRes AskPluginLoad2(Handle myself, bool late, char[] error, int err_max

CreateNative("SBBanPlayer", Native_SBBanPlayer);
CreateNative("SBPP_BanPlayer", Native_SBBanPlayer);
CreateNative("SBPP_BanPlayerBySteamId", Native_SBPP_BanPlayerBySteamId);
CreateNative("SBPP_ReportPlayer", Native_SBReportPlayer);

g_hFwd_OnBanAdded = CreateGlobalForward("SBPP_OnBanPlayer", ET_Ignore, Param_Cell, Param_Cell, Param_Cell, Param_String);
Expand Down Expand Up @@ -2382,6 +2383,148 @@ public int Native_SBBanPlayer(Handle plugin, int numParams)
return true;
}

public int Native_SBPP_BanPlayerBySteamId(Handle plugin, int numParams)
{
if (DB == INVALID_HANDLE)
{
ThrowNativeError(SP_ERROR_NATIVE, "SourceBans++ database is not available.");
return 0;
}

int admin = GetNativeCell(1);
int iTime = GetNativeCell(4);

char steamId[MAX_AUTHID_LENGTH], name[MAX_NAME_LENGTH], reason[128];
GetNativeString(2, steamId, sizeof(steamId));
GetNativeString(3, name, sizeof(name));
GetNativeString(5, reason, sizeof(reason));

if (strncmp(steamId, "STEAM_", 6, false) != 0)
{
ThrowNativeError(SP_ERROR_NATIVE, "SBPP_BanPlayerBySteamId: steamId must be in SteamID2 format (STEAM_X:Y:Z), got: %s", steamId);
return 0;
}

if (reason[0] == '\0')
strcopy(reason, sizeof(reason), "Banned by SourceBans");

char adminAuth[MAX_AUTHID_LENGTH], adminIp[16];
if (!admin || !IsClientInGame(admin))
{
strcopy(adminAuth, sizeof(adminAuth), "STEAM_ID_SERVER");
strcopy(adminIp, sizeof(adminIp), ServerIp);
}
else
{
strcopy(adminAuth, sizeof(adminAuth), g_sSteamIDs[admin]);
strcopy(adminIp, sizeof(adminIp), g_sPlayerIP[admin]);
}

DataPack pack = new DataPack();
pack.WriteCell(admin);
pack.WriteCell(iTime);
pack.WriteString(reason);
pack.WriteString(steamId);
pack.WriteString(name);
pack.WriteString(adminAuth);
pack.WriteString(adminIp);

char steamIdEscaped[MAX_AUTHID_LENGTH * 2 + 1];

@rumblefrog rumblefrog Jun 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check for steamid type since enforcement is done with SteamID2

@Sigibert Sigibert Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a SteamID2 format check to the steamId provided by the native. Hope that fits ur concerns.

DB.Escape(steamId, steamIdEscaped, sizeof(steamIdEscaped));

char query[512];
FormatEx(query, sizeof(query), "SELECT bid FROM %s_bans WHERE type = 0 AND authid = '%s' AND (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL",
DatabasePrefix, steamIdEscaped);

DB.Query(DB_OnBanBySteamIdSelect, query, pack, DBPrio_High);

return 0;
}

void DB_OnBanBySteamIdSelect(Database db, DBResultSet results, const char[] error, DataPack pack)
{
if (results == null)
{
LogToFile(logFile, "[SBPP] BanPlayerBySteamId select failed: %s", error);
delete pack;
return;
}

pack.Reset();
int admin = pack.ReadCell();
int iTime = pack.ReadCell();
char reason[128], steamId[MAX_AUTHID_LENGTH], name[MAX_NAME_LENGTH], adminAuth[MAX_AUTHID_LENGTH], adminIp[16];
pack.ReadString(reason, sizeof(reason));
pack.ReadString(steamId, sizeof(steamId));
pack.ReadString(name, sizeof(name));
pack.ReadString(adminAuth, sizeof(adminAuth));
pack.ReadString(adminIp, sizeof(adminIp));
delete pack;

if (results.RowCount > 0)
{
LogToFile(logFile, "[SBPP] BanPlayerBySteamId: %s is already banned, skipping.", steamId);
return;
}

char steamIdEscaped[MAX_AUTHID_LENGTH * 2 + 1], nameEscaped[MAX_NAME_LENGTH * 2 + 1], reasonEscaped[256];
DB.Escape(steamId, steamIdEscaped, sizeof(steamIdEscaped));
DB.Escape(name, nameEscaped, sizeof(nameEscaped));
DB.Escape(reason, reasonEscaped, sizeof(reasonEscaped));

char query[1024];
if (serverID == -1)
{
FormatEx(query, sizeof(query), "INSERT INTO %s_bans (authid, name, created, ends, length, reason, aid, adminIp, sid, country) VALUES \
('%s', '%s', UNIX_TIMESTAMP(), UNIX_TIMESTAMP() + %d, %d, '%s', \
IFNULL((SELECT aid FROM %s_admins WHERE authid = '%s' OR authid REGEXP '^STEAM_[0-9]:%s$'),'0'), '%s', \
(SELECT sid FROM %s_servers WHERE ip = '%s' AND port = '%s' LIMIT 0,1), ' ')",
DatabasePrefix, steamIdEscaped, nameEscaped, (iTime * 60), (iTime * 60), reasonEscaped,
DatabasePrefix, adminAuth, adminAuth[8], adminIp,
DatabasePrefix, ServerIp, ServerPort);
}
else
{
FormatEx(query, sizeof(query), "INSERT INTO %s_bans (authid, name, created, ends, length, reason, aid, adminIp, sid, country) VALUES \
('%s', '%s', UNIX_TIMESTAMP(), UNIX_TIMESTAMP() + %d, %d, '%s', \
IFNULL((SELECT aid FROM %s_admins WHERE authid = '%s' OR authid REGEXP '^STEAM_[0-9]:%s$'),'0'), '%s', \
%d, ' ')",
DatabasePrefix, steamIdEscaped, nameEscaped, (iTime * 60), (iTime * 60), reasonEscaped,
DatabasePrefix, adminAuth, adminAuth[8], adminIp,
serverID);
}

DataPack fwdPack = new DataPack();
fwdPack.WriteCell(admin);
fwdPack.WriteCell(iTime);
fwdPack.WriteString(reason);

DB.Query(DB_OnBanBySteamIdInsert, query, fwdPack, DBPrio_High);
}

void DB_OnBanBySteamIdInsert(Database db, DBResultSet results, const char[] error, DataPack pack)
{
pack.Reset();
int admin = pack.ReadCell();
int iTime = pack.ReadCell();
char reason[128];
pack.ReadString(reason, sizeof(reason));
delete pack;

if (results == null)
{
LogToFile(logFile, "[SBPP] BanPlayerBySteamId insert failed: %s", error);
return;
}

Call_StartForward(g_hFwd_OnBanAdded);
Call_PushCell(admin);
Call_PushCell(-1);
Call_PushCell(iTime);
Call_PushString(reason);
Call_Finish();
}

public int Native_SBReportPlayer(Handle plugin, int numParams)
{
if (numParams < 3)
Expand Down
Loading