fix(admin-servers): vertically align Server ID value with its label#1525
Merged
Conversation
Follow-up to #1523. The Server ID row's <dd> is a flex container whose copy button (btn--xs, 1.5rem) makes the row taller than one line of text, while the sibling <dt> label inherited the grid's default align-items:stretch and sat top-aligned, so the ID read as dropped below its "Server ID" label. Add align-items:center to the card's inner <dl> so every label/value pair lines up on the same vertical level; the single-line Mod/Players/Map rows are unaffected (center vs stretch is a no-op at equal height).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1523.
#1523 added a labelled, copyable Server ID row to each admin server card. The row's
<dd>is a flex container (display:flex;align-items:center) whose copy button (btn btn--ghost btn--icon btn--xs, 1.5rem tall) makes the row taller than a single line of text. Its sibling<dt>label inherited the<dl>grid's defaultalign-items:stretch, so the label sat top-aligned while the button-driven value centered. The result: the numeric ID reads as dropped below its "Server ID" label instead of sitting inline with it.This adds
align-items:centerto the card's inner<dl>grid inweb/themes/default/page_admin_servers_list.tplso every label/value pair lines up on the same vertical level.centervsstretchis a visual no-op (no regression). Their hydrated cells (server-players/server-map) are patched with single-linetextContent, so nothing multi-line is affected.Template-only change: one inline-CSS property + an explanatory comment. No new Smarty variables, testids, or content, so it doesn't touch the
SmartyTemplateRule(PHPStan) contract,AdminServersListHydrationTest(asserts testids/content), ts-check, or theadmin-server-id.spec.tsrender contract.Test plan
AdminServersListHydrationTest::testTileRendersCopyableServerIdassertions (testids/value/copy payload/label) still hold — structure unchanged.