Skip to content

fix(oxlint): fix eslint/no-console violations #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philibea wants to merge 1 commit into from
Closed

fix(oxlint): fix eslint/no-console violations #3766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion oxlint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export default defineConfig({
'eslint/max-depth': 'warn',
'eslint/max-params': 'warn',
'eslint/no-await-in-loop': 'warn',
'eslint/no-console': 'warn',
'eslint/no-implicit-coercion': 'warn',
'eslint/no-throw-literal': 'warn',
'eslint/prefer-destructuring': 'warn',
Expand Down
24 changes: 14 additions & 10 deletions packages/changesets-renovate/src/__tests__/generate-changeset.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { readFile, writeFile } from 'node:fs/promises'
import { defaultConfig, readConfig } from '@changesets/config'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import type { MockInstance } from 'vitest'
import { defaultGitValues, mockSimpleGit } from '../../__mocks__/simple-git'
import { run } from '../generateChangeset.js'

Expand All @@ -21,8 +22,11 @@ const mockedWriteFile = vi.mocked(writeFile)
const mockedReadFile = vi.mocked(readFile)

describe('generate changeset file', () => {
// oxlint-disable-next-line eslint/init-declarations -- assigned in beforeEach

@chambo-e chambo-e Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

let consoleLogSpy: MockInstance<typeof console.log>

beforeEach(() => {
vi.spyOn(console, 'log')
consoleLogSpy = vi.spyOn(console, 'log')
vi.mocked(readConfig).mockResolvedValue({
config: defaultConfig,
warnings: [],
Expand Down Expand Up @@ -50,7 +54,7 @@ describe('generate changeset file', () => {

await run()

expect(console.log).toHaveBeenCalledWith('Not a renovate branch, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('Not a renovate branch, skipping')
})

it('should not skip if branch starts with custom branch prefix', async () => {
Expand Down Expand Up @@ -95,7 +99,7 @@ describe('generate changeset file', () => {
process.env['BRANCH_PREFIX'] = 'dep-upgrade/'
await run()

expect(console.log).not.toHaveBeenCalledWith('Not a renovate branch, skipping')
expect(consoleLogSpy).not.toHaveBeenCalledWith('Not a renovate branch, skipping')
expect(mockedReadFile).toHaveBeenCalledWith(file, 'utf8')
expect(mockedWriteFile).toMatchSnapshot()
expect(add).toHaveBeenCalledWith(fileName)
Expand Down Expand Up @@ -145,7 +149,7 @@ describe('generate changeset file', () => {
process.env['SKIP_BRANCH_CHECK'] = 'TRUE'
await run()

expect(console.log).not.toHaveBeenCalledWith('Not a renovate branch, skipping')
expect(consoleLogSpy).not.toHaveBeenCalledWith('Not a renovate branch, skipping')
expect(mockedReadFile).toHaveBeenCalledWith(file, 'utf8')
expect(mockedWriteFile).toMatchSnapshot()
expect(add).toHaveBeenCalledWith(fileName)
Expand All @@ -171,7 +175,7 @@ describe('generate changeset file', () => {

await run()

expect(console.log).toHaveBeenCalledWith('Changeset already exists, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('Changeset already exists, skipping')
})

it('should skip no package.json files have been modified', async () => {
Expand All @@ -188,7 +192,7 @@ describe('generate changeset file', () => {

await run()

expect(console.log).toHaveBeenCalledWith('No relevant changes detected, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('No relevant changes detected, skipping')
})

it('should generate changeset file, commit and push', async () => {
Expand Down Expand Up @@ -379,7 +383,7 @@ describe('generate changeset file', () => {
await run()

expect(mockedReadFile).toHaveBeenCalledWith(file, 'utf8')
expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('No packages modified, skipping')
})

it('should ignore version package.json', async () => {
Expand Down Expand Up @@ -415,7 +419,7 @@ describe('generate changeset file', () => {
await run()

expect(mockedReadFile).toHaveBeenCalledWith(file, 'utf8')
expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('No packages modified, skipping')
})

it('should ignore changeset ignored packages', async () => {
Expand Down Expand Up @@ -457,7 +461,7 @@ describe('generate changeset file', () => {
await run()

expect(mockedReadFile).toHaveBeenCalledWith(file, 'utf8')
expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('No packages modified, skipping')
})

it('should ignore private packages if config said so', async () => {
Expand Down Expand Up @@ -502,6 +506,6 @@ describe('generate changeset file', () => {
await run()

expect(mockedReadFile).toHaveBeenCalledWith(file, 'utf8')
expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
expect(consoleLogSpy).toHaveBeenCalledWith('No packages modified, skipping')
})
})
Loading