pop_topoplot: fix ERP map channel alignment when channels lack locations - #952
Open
innaamogolonova wants to merge 1 commit into
Open
pop_topoplot: fix ERP map channel alignment when channels lack locations#952innaamogolonova wants to merge 1 commit into
innaamogolonova wants to merge 1 commit into
Conversation
Build SIGTMPAVG as a full nbchan-row array so each located channel's mean maps to its true channel row. Previously only located channels were passed (a shorter vector) alongside the full chanlocs, so datasets with interspersed no-location channels (e.g. EOG) shifted the plotted data onto wrong electrodes.
Collaborator
|
@claude please review this change. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pop_topoplotpassed only located-channel values alongside the fullchanlocs, so datasets with interspersed no-location channels (e.g. EOG) plotted ERP data on the wrong electrodes. This buildsSIGTMPAVGas a fullnbchan-row array so each channel's value maps to its correct location.