Merged
Conversation
Contributor
Author
|
Well, it works now, but following the example here does not. |
Contributor
Author
|
After bugfixing, this passes on Ubuntu but fails on MacOS because the image does not have a Fortran compiler https://github.com/frank1010111/scikit-build-sample-projects/actions/runs/4355492884. There is a Fortran compiler action which could resolve that in Windows and Mac. |
Contributor
Author
|
The example now works for both Mac and Linux. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Contributor
|
Thanks! I moved it to scikit-build-core and went with this over #35 since it avoided the scikit-build only module. |
coltonjgerber
pushed a commit
to coltongerber/pylada-light
that referenced
this pull request
Jul 26, 2024
bugfix: Add NumPy headers to CMakeLists.txt, per commit scikit-build/scikit-build-sample-projects@5ad5096 at scikit-build/scikit-build-sample-projects#32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sample project with fortran, compiled with f2py run by scikit-build and cmake.
This would close #29.