Check xlink:href for gradientUnits="userSpaceOnUse" - #271
Open
nthykier wants to merge 1 commit into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 94.08% 94.05% -0.04%
==========================================
Files 6 6
Lines 2264 2286 +22
==========================================
+ Hits 2130 2150 +20
- Misses 134 136 +2
Continue to review full report at Codecov.
|
When considering to prune attributes set to a default values, we checked the `gradientUnits` attribute first to determine if that was valid. Unfortunately, we omitted to check whether the `gradientUnits` attribute was inherited via `xlink:ref`. This commit corrects that bug. Closes: scour-project#225 Signed-off-by: Niels Thykier <niels@thykier.net>
nthykier
force-pushed
the
gh-225-gradient-fix
branch
from
February 28, 2021 15:09
e4c3bf1 to
e0e3f81
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 94.08% 94.05% -0.04%
==========================================
Files 6 6
Lines 2264 2286 +22
==========================================
+ Hits 2130 2150 +20
- Misses 134 136 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When considering to prune attributes set to a default values, we
checked the
gradientUnitsattribute first to determine if that wasvalid. Unfortunately, we omitted to check whether the
gradientUnitsattribute was inherited via
xlink:ref. This commit corrects thatbug.
Closes: #225
Signed-off-by: Niels Thykier niels@thykier.net