馃敤 Make RoomPosition.findClosestByPath respect the passed range - #160
Open
tiennou wants to merge 1 commit into
Open
馃敤 Make RoomPosition.findClosestByPath respect the passed range#160tiennou wants to merge 1 commit into
tiennou wants to merge 1 commit into
Conversation
The docs says `see Room.findPath` when describing the options it takes. Those are passed into the costmatrix, so some get applied. But range doesn't, and instead gets hardcoded to 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs says
see Room.findPathwhen describing the options it takes. Those are passed into the costmatrix, so some get applied. But range doesn't, and instead gets hardcoded to 1.