test: fix docker test and build over main branch#478
Open
lopezator wants to merge 1 commit intosendgrid:mainfrom
Open
test: fix docker test and build over main branch#478lopezator wants to merge 1 commit intosendgrid:mainfrom
lopezator wants to merge 1 commit intosendgrid:mainfrom
Conversation
- Remove the dependency from the sendgrid-oai repo and prism. - Build and start containers on test target on a single statement. This should fix the builds over the main branch, because `docker-compose` is compose v1 which has been deprecated and not installed on newest versions of github actions `ubuntu-latest`. more info: https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2
lopezator
force-pushed
the
feature/docker-compose-v2
branch
from
6ac158c to
f35546d
Compare
lopezator
changed the title
Contributor
Author
|
CC/ @sbansla |
8 tasks
sbansla
reviewed
Aug 6, 2024
| test-docker: | ||
| curl -s https://raw.githubusercontent.com/sendgrid/sendgrid-oai/HEAD/prism/prism.sh -o prism.sh | ||
| version=$(version) bash ./prism.sh | ||
| docker compose up --build --parallel --force-recreate --abort-on-container-exit --remove-orphans |
Contributor
There was a problem hiding this comment.
docker-compose.yml file is present in sendgrid/sendgrid-oai project.
We need to clone that project.
Contributor
Author
There was a problem hiding this comment.
Ouch I see. But that project is archived. Is there any newer alternative or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes the builds over the main branch removing the dependency from sendgrid-oai repository, prism and docker compose v1.
Checklist