Reduce response contents to remove unneeded fields#1073
Merged
Conversation
gavinelder
marked this pull request as ready for review
July 9, 2026 10:14
Keep the existing response shapes for both container-detail endpoints and
only remove the user name and email from the serialized identity:
- GET /v1alpha2/container/{requestId} continues to return WaveContainerRecord;
the user is reduced to an id-only copy via WaveContainerRecord.withoutUserDetails()
- DescribeWaveContainerResponse.RequestInfo keeps the User-typed `user` field
but populates only the id via User.ofId()
- Revert the TypeSpec route/model back to WaveContainerRecord
- Mail service is unaffected: it reads the live request identity and still
sends to user.email
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pditommaso
approved these changes
Jul 14, 2026
pditommaso
left a comment
pditommaso
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed for breaking changes: verified none of the Wave ecosystem clients (nextflow nf-wave, wave-cli, platform, sched, seqera-mcp) consume the two affected describe endpoints — all use submit + status/build/inspect paths that don't carry the stripped user fields. PII reduction is non-breaking for API clients. Applied minor rename withoutUserDetails() → withUserIdOnly() for clarity. LGTM.
Collaborator
|
Small follow-up: I pushed a one-line rename |
Contributor
Author
|
LGTM on the change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v1alpha2/container/{requestId}still returnsWaveContainerRecord; the user is reduced to an id-only copy viaWaveContainerRecord.withoutUserDetails()DescribeWaveContainerResponse.RequestInfokeeps theUser-typeduserfield but populates only the id via the newUser.ofId(...)factoryuser.emailNotes
Userclass itself is unchanged (no@JsonIgnore), so name/email remain available to the mail service and internal flowsNON_ABSENT, an id-only user serializes as{"id":...}— same object shape, no name/email leakedWaveContainerRecord(no new response model), matching the unchanged wire shapeTests
./gradlew generateOpenApi :test --tests 'io.seqera.wave.exchange.DescribeWaveContainerResponseTest' --tests 'io.seqera.wave.controller.ContainerControllerTest.should return the container record' --tests 'io.seqera.wave.controller.ViewControllerTest.should create build binding' --tests 'io.seqera.wave.controller.ViewControllerTest.should render build page' --tests 'io.seqera.wave.controller.ViewControllerTest.should render container view page' --tests 'io.seqera.wave.controller.ViewControllerTest.should render in progress build page' --tests 'io.seqera.wave.controller.ViewControllerTest.should render mirror page'