Add global flag to disable Wave HTML view pages#1086
Open
gavinelder wants to merge 4 commits into
Open
Conversation
Introduce an installation-level configuration flag 'wave.views.enabled' (default true). When set to false, the HTML view pages served under /view/** (builds, mirrors, scans, containers, inspect) are disabled globally via a class-level @requires on ViewController, so the whole /view surface returns 404. Default behaviour is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…/absence Add ViewControllerEnabledTest asserting the ViewController bean is loaded when wave.views.enabled=true, and assert bean absence in the disabled test, so the flag is verified in both directions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gavinelder
marked this pull request as ready for review
July 16, 2026 15:07
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cristianrcv
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an installation-level configuration flag
wave.views.enabled(defaulttrue) that lets operators globally turn off the HTML view pages Wave serves under/view/**— the build, mirror, scan, container, and inspect pages.When
wave.views.enabled=false,ViewControlleris not loaded (class-level@Requires), so the entire/view/**surface returns404. Default behaviour is unchanged, so this is fully backward compatible.Changes
ViewController: class-level@Requires(property = 'wave.views.enabled', value = 'true', defaultValue = 'true').application.yml: documented defaultwave.views.enabled: true.ViewControllerDisabledTest: asserts/view/**returns404when the flag isfalse.Testing
ViewControllerDisabledTestpasses (4/4).ViewControllerTestis unchanged: the same 4 environment-dependent tests (inspectviews and thescan-redirect) fail on bothmasterand this branch, so no new failures are introduced by this change.🤖 Generated with Claude Code