Add global wave.inject-credentials flag to control proxy-pull credential injection#1088
Open
gavinelder wants to merge 3 commits into
Open
Add global wave.inject-credentials flag to control proxy-pull credential injection#1088gavinelder wants to merge 3 commits into
gavinelder wants to merge 3 commits into
Conversation
…al injection Introduce an installation-level flag 'wave.inject-credentials' (default true). When false, RegistryProxyService no longer injects/brokers registry credentials on the proxy-pull path (getCredentials returns null), so images are pulled directly from the target registry with the caller's own credentials. Build, inspect and augmentation credential resolution are unaffected. Default behaviour is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gavinelder
marked this pull request as ready for review
July 16, 2026 15:54
cristianrcv
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an installation-level configuration flag
wave.inject-credentials(defaulttrue). When set tofalse, Wave no longer injects/brokers registry credentials on the proxy-pull path —RegistryProxyService.getCredentialsreturns no credentials — so images are expected to be pulled directly from the target registry using the caller's own credentials (for example an EC2 instance profile / IAM role). This gives pulls native attribution in the target registry's own logs and removes an unnecessary credential-brokering step where compute already has access.Build, inspect and augmentation credential resolution use separate call sites and are unaffected. Default is
true, so existing deployments behave exactly as before.Changes
RegistryProxyService:@Value('${wave.inject-credentials:true}')flag;getCredentialsreturnsnullwhen disabled (the same anonymous path already used for public images).application.yml: documented defaultwave.inject-credentials: true.RegistryProxyServiceCredentialsTest: verifies the flag gates credential resolution (disabled → no provider call,null; enabled → delegates to the provider).Scope
Scoped to Wave's registry-proxy credential injection (proxy pulls and request-time digest resolution). It does not change how image references are presented to clients, nor build/freeze/mirror credential brokering.
Testing
RegistryProxyServiceCredentialsTestpasses (2/2).RegistryProxyServiceTestis unchanged: its one failing case (should retrieve image digest) fails identically onmaster(it reaches a live registry), so no new failures are introduced by this change.🤖 Generated with Claude Code