feature: consolidate capability toggles under wave.capabilities.*#1098
Merged
Conversation
cristianrcv
approved these changes
Jul 23, 2026
gavinelder
approved these changes
Jul 23, 2026
gavinelder
left a comment
Contributor
There was a problem hiding this comment.
I don't feel I deserve the attribution within the codebase the clean improvements to the variable names to declare intent are well thought out and provide a strong level of clarity.
Groups the installation-level capability toggles under a single, consistent `wave.capabilities.*` config namespace (all default `true`), and adds a `strict` environment (application-strict.yml) that disables them all at once for locked-down / regulated deployments. - wave.capabilities.ephemeral-token (renames wave.container.pull.enabled, #1089) - wave.capabilities.credentials-federation (supersedes wave.inject-credentials, #1088) - wave.capabilities.web-views (supersedes wave.views.enabled, #1086) Javadocs, error/log messages and user documentation updated accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds anonymous access as a capability toggle (default true). The legacy `wave.allowAnonymous` key still works as an undocumented backward-compat alias via the config fallback expression, and is disabled in the `strict` environment. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds AnonymousAccessLegacyAliasTest proving the legacy `wave.allowAnonymous` key still drives `wave.capabilities.anonymous-access` (unset → true default; false/true overrides honored). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pditommaso
force-pushed
the
capabilities-config-group
branch
from
July 23, 2026 12:46
0c93e8c to
acec05b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Groups Wave's installation-level capability toggles under a single, consistent
wave.capabilities.*namespace, and adds astrictenvironment that disables them all at once for locked-down / regulated deployments.Previously these landed with inconsistent shapes:
wave.allowAnonymous(flat),wave.container.pull.enabled(nested),wave.inject-credentials(flat, top-level), andwave.views.enabled(nested). This unifies them.true)falsedoeswave.capabilities.anonymous-accesswave.capabilities.ephemeral-tokenfreezemodewave.capabilities.credentials-federation/view/**wave.capabilities.web-viewsViewControllernot loaded →404All flags default to
true(permissive) so existing deployments behave exactly as before. The newstrictenvironment (application-strict.yml, enabled withMICRONAUT_ENVIRONMENTS=strict) sets all four tofalse.Changes
ContainerController— renameswave.container.pull.enabled→wave.capabilities.ephemeral-token(fieldallowPull→ephemeralToken); reads anonymous access fromwave.capabilities.anonymous-access; rejection message updated to reflect the new naming.RegistryProxyService— addswave.capabilities.credentials-federationgatinggetCredentialson the proxy-pull path.ViewController— class-level@Requires(property = 'wave.capabilities.web-views', ...).application.yml— newwave.capabilitiesblock with documented defaults.application-strict.yml— new env profile disabling all capabilities.docs/configuration.md— new Capabilities section documenting all four flags and thestrictenvironment.Backward compatibility
Defaults unchanged (all
true) — no behavior change for existing installs.The legacy
wave.allowAnonymouskey still works as an undocumented alias:application.ymlresolvesanonymous-accessfrom${wave.allowAnonymous:true}, so operators who still set the old key are honored (no default shadows it). Covered byAnonymousAccessLegacyAliasTest:wave.allowAnonymousanonymous-accesstrue(default)falsefalsetruetrueRelated PRs
wave.inject-credentials→wave.capabilities.credentials-federation).wave.views.enabled→wave.capabilities.web-views).Test specs from #1088 and #1086 are reproduced here under the new keys, preserving original authorship.
Testing
./gradlew :test— all pass:ContainerControllerTestRegistryProxyServiceCredentialsTestViewControllerDisabledTest/ViewControllerEnabledTestAnonymousAccessLegacyAliasTest🤖 Generated with Claude Code