Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Add buildbot 0.9 support steps in README.md - #119

Open
coldnight wants to merge 3 commits into
servo:masterfrom
coldnight:master
Open

Add buildbot 0.9 support steps in README.md#119
coldnight wants to merge 3 commits into
servo:masterfrom
coldnight:master

Conversation

@coldnight

@coldnight coldnight commented May 18, 2017

Copy link
Copy Markdown

Same propose with #115 but in different way.

Inspired by this comment
I have tried in my own project, and it works. So I add the steps into
README.md.


This change is Reviewable

Comment thread README.md Outdated
- Buildbot 0.9 via GithubStatusPush

Buildbot 0.9 support [GithubStatusPush](http://docs.buildbot.net/latest/manual/cfg-reporters.html#githubstatuspush),
so we can use this to integrate with Github and Buildbot 0.9.

@atouchet atouchet May 18, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "H" in GitHubStatusPush and GitHub should be capitalized.

There are a few more instances of these below as well.

@coldnight

Copy link
Copy Markdown
Author

@atouchet I have fixed that.

@atouchet

Copy link
Copy Markdown

@coldnight "GithubStatusPush" still needs to be fixed.

@coldnight

Copy link
Copy Markdown
Author

@atouchet Sorry I miss that. Now that was fixed.

@Manishearth

Copy link
Copy Markdown
Member

(note: won't have time to review this for a few weeks)

@bors-servo

Copy link
Copy Markdown

☔ The latest upstream changes (presumably #117) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants