Fetch current_epoch via render_api#4877
Conversation
bef2bd2 to
caad7a6
Compare
d35bbfe to
596f3f3
Compare
596f3f3 to
92f36fd
Compare
|
@mrobinson @xiaochengh Please take a look. |
yezhizhen
left a comment
There was a problem hiding this comment.
Let's fix the CI first. Can you explain the motivation of "synchronous", and how is it achieved?
92f36fd to
7d2e592
Compare
Please run the workflow again. I updated the PR description. PTAL. |
|
Could you elaborate on the motivation of this PR? Why do we prefer a sync api over an async one? Is there any issue with the current async API? Or do you just want to make it easier to call (which on its own might not justify the change though...)? |
render_apicurrent_epoch via render_api
I updated the PR description. Please take a look. |
|
I'm also curious about the motivations here. I don't really great about making large architectural changes to WebRender. It's better to have fewer changes on top of the upstream version. The exception is for solving a problem that we are encountering. In that case, we should discuss with the folks at Mozilla about making our changes upstream or look at reworking the code in Servo. |
bfd0b6b to
8c1bfc3
Compare
mrobinson
left a comment
There was a problem hiding this comment.
Regarding this change: we try to keep our modifications to WebRender as minimal as possible and limited just to things that Servo needs. If you feel like this could be generally useful, a good step might be to submit it upstream to the Gecko repository and see if it's something that also makes sense for Firefox as well. If it lands upstream, it will also be available the next time we re-sync WebRender with upstream.
4739d43 to
d14aafe
Compare
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
d14aafe to
dcba2bb
Compare
This PR targets to access the
Scene'sPipelineInfousingrender_api.Aiming
render_apias only interface used to communicate withWebRender.As of now
render_apiis already being used for most of communication except this one (andupdate).In this PR
pipeline_infois moved toSceneBuilderThreadalong withremoved_pipelines.PublishPipelineInfotoSceneBuilerThread.pipeline_infosynchronous as earlier we need to rely on calling ofrenderer.update()toPublishPipelineInfo. Now using event loop ofSceneBuilerThreadit is synchronous.Add-ons
4.
FlushPipelineInfois also connected toSceneBuilerThreadas required.