Draft
Conversation
Owner
sevensolutions
left a comment
sevensolutions
left a comment
There was a problem hiding this comment.
Hi @cdanis
thx for this PR 👍
I think you're still working on it, but I thought I'd start by adding my two cents 😂
| //Scopes: []string{"openid", "profile", "email"}, | ||
| CallbackUri: "/oidc/callback", | ||
| LogoutUri: "/logout", | ||
| FrontChannelLogoutUri: "/frontchannel-logout", |
Owner
There was a problem hiding this comment.
Should we support environment variable expansion?
| toa.handleLogout(rw, req, session) | ||
| return | ||
| } | ||
| if toa.Config.FrontChannelLogoutUri != "" && strings.HasPrefix(req.RequestURI, toa.Config.FrontChannelLogoutUri) { |
Owner
There was a problem hiding this comment.
I think I would prefer to move this before the if err == nil && session != nil { and then pass in the "optional" session and claims.
Then we can handle both cases (with and without session) within the handleFrontChannelLogout function and we have everything in one place.
Eg:
session, updateSession, claims, err := toa.getSessionForRequest(req)
// Handle front-channel logout
if err == nil && strings.HasPrefix(req.RequestURI, toa.Config.FrontChannelLogoutUri) {
toa.handleFrontChannelLogout(rw, req, session, claims)
return
}What do you think?
Contributor
Author
|
I'll get back to this soon I hope 😅 but yes, not done yet. Aside from review comments, I also wanted to generate formatted error responses, and do some more testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197