refactor: index.tsのclient.onを分割し、マジックナンバーを削減

src/env.ts

@@ -0,0 +1,9 @@
+import dotenv from "dotenv"
+
+dotenv.config()
+
+export const env = {
+  tokens: {
+    discordToken: process.env.DISCORD_TOKEN
+  }
+}

src/handlers/events/onMessageReactionAdd.ts

@@ -0,0 +1,25 @@
+import type { MessageReaction, PartialMessageReaction, User, PartialUser } from "discord.js";
+
+import addReactionRole from "../../services/reactionRole/addReactionRole";
+
+export default async function onMessageReactionAdd(reaction: MessageReaction | PartialMessageReaction, user: User | PartialUser) {
+  const message = reaction.message;
+  const member = message?.guild?.members.resolve(user.id);
+
+  console.log("[INFO]  messageReactionAdded");
+  console.log(`   -> message: ${message.content?.toString()}`);
+  console.log(`   -> member : ${member?.displayName}`);
+
+  if (!member || !reaction.emoji.name) return;
+
+  console.log(`   -> react  : ${reaction.emoji.name}`);
+
+  // ReactionRole: ロール付与
+  if (message.id === reactionRoleMessage) {
+    try {
+      await addReactionRole(member, reaction.emoji.name);
+    } catch (e) {
+      console.error(e);
+    }
+  }
+});

src/handlers/events/onMessageReactionRemove.ts

@@ -0,0 +1,25 @@
+import type { MessageReaction, PartialMessageReaction, PartialUser, User } from "discord.js";
+import removeReactionRole from "../../services/reactionRole/removeReactionRole";
+
+export default async function onMessageReactionRemove(reaction: MessageReaction | PartialMessageReaction, user: User | PartialUser) {
+  const message = reaction.message;
+  const member = message?.guild?.members.resolve(user.id);
+
+  console.log("[INFO]  messageReactionAdded");
+  console.log(`   -> message: ${message.content?.toString()}`);
+  console.log(`   -> member : ${member?.displayName}`);
+
+  if (!member || !reaction.emoji.name) return;
+
+  console.log(`   -> react  : ${reaction.emoji.name}`);
+
+  // ReactionRole: ロール剥奪
+  if (message.id === reactionRoleMessage) {
+    try {
+      await removeReactionRole(member, reaction.emoji.name);
+    } catch (e) {
+      console.error(e);
+      // この先通知処理も追加
+    }
+  }
+}

src/index.ts

@@ -14,13 +14,11 @@ import { handleVcLeave } from "./handlers/events/vc/leave";
 import { handleVcLogger } from "./handlers/events/vc/logger";
 import { updateMemberCount, firstJob } from "./jobs/updateMemberCount";
 import { loadCommands, loadActions } from "./utils/loader";
-import dotenv from "dotenv";
 import noticeNewRecruit from "./jobs/noticeNewRecruit";
-import addReactionRole from "./handlers/events/reactionRole/addReactionRole";
-import removeReactionRole from "./handlers/events/reactionRole/removeReactionRole";
 import checkReactionRoleMessage from "./jobs/checkReactionRoleMessage";
-
-dotenv.config({ path: ".env" });
+import onMessageReactionRemove from "./handlers/events/onMessageReactionRemove";
+import onMessageReactionAdd from "./handlers/events/onMessageReactionAdd";
+import { env } from "./env";
 
 // 実行環境に応じてファイルタイプとディレクトリを決定
 const FILE_TYPE: string = process.argv[2] === "js" ? ".js" : ".ts";
@@ -275,52 +273,10 @@ client.on("guildMemberUpdate", async (oldMember, newMember) => {
   }
 });
 
-client.on("messageReactionAdd", async (reaction, user) => {
-  const message = reaction.message;
-  const member = message?.guild?.members.resolve(user.id);
-
-  console.log("[INFO]  messageReactionAdded");
-  console.log(`   -> message: ${message.content?.toString()}`);
-  console.log(`   -> member : ${member?.displayName}`);
-
-  if (!member || !reaction.emoji.name) return;
-
-  console.log(`   -> react  : ${reaction.emoji.name}`);
-
-  // ReactionRole: ロール付与
-  if (message.id === reactionRoleMessage) {
-    try {
-      await addReactionRole(member, reaction.emoji.name);
-    } catch (e) {
-      console.error(e);
-    }
-  }
-});
-
-client.on("messageReactionRemove", async (reaction, user) => {
-  const message = reaction.message;
-  const member = message?.guild?.members.resolve(user.id);
-
-  console.log("[INFO]  messageReactionAdded");
-  console.log(`   -> message: ${message.content?.toString()}`);
-  console.log(`   -> member : ${member?.displayName}`);
-
-  if (!member || !reaction.emoji.name) return;
-
-  console.log(`   -> react  : ${reaction.emoji.name}`);
-
-  // ReactionRole: ロール剥奪
-  if (message.id === reactionRoleMessage) {
-    try {
-      await removeReactionRole(member, reaction.emoji.name);
-    } catch (e) {
-      console.error(e);
-      // この先通知処理も追加
-    }
-  }
-});
+client.on("messageReactionAdd", onMessageReactionAdd);
+client.on("messageReactionRemove", onMessageReactionRemove);
 
 export { FILE_TYPE, client, commands, actions };
-client.login(process.env.DISCORD_TOKEN).catch((error) => {
+client.login(env.tokens.discordToken).catch((error) => {
   console.error("[ERROR] Failed to login Discord client:", error);
 });